Skip to content

Add fresh snapshot-family bootstrap regression coverage #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keegreil merged 1 commit into from
Sep 13, 2026
Merged

Add fresh snapshot-family bootstrap regression coverage #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions boot.tests/ShareAttributionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1477,6 +1477,23 @@ public void FullReserveImportAllowsOneSnapshotContextPerBoundedProof()
Assert.IsTrue(BootProtocolStateService.GetMaxImportedSnapshotContextCount(config) >= 396);
}

[TestMethod]
public void FreshProductionPlaceholderDoesNotEnterSiblingReconciliation()
{
Assert.IsFalse(BootProtocolStateService.ShouldReconcileSnapshotFamily(
hasLocalActiveFamily: true,
localStateIsEmpty: true,
allowEmptySnapshotBootstrap: false));
Assert.IsTrue(BootProtocolStateService.ShouldReconcileSnapshotFamily(
hasLocalActiveFamily: true,
localStateIsEmpty: false,
allowEmptySnapshotBootstrap: false));
Assert.IsTrue(BootProtocolStateService.ShouldReconcileSnapshotFamily(
hasLocalActiveFamily: true,
localStateIsEmpty: true,
allowEmptySnapshotBootstrap: true));
}

[TestMethod]
public async Task RegtestSiblingImportAcceptsProofRecordedAgainstExplicitEmptyBootstrapSnapshotAsync()
{
Expand Down
14 changes: 12 additions & 2 deletions boot_portal/Services/BootProtocolStateService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4659,8 +4659,10 @@ public async Task<bool> TryAdoptCurrentStateAsync(BootStateBundle bundle, string
}
if (GetActiveConsensusVersion() >= BootProtocolVersions.ConsensusVersion &&
bundle.SnapshotFamilyMember != null &&
hasLocalActiveFamily &&
(!localStateIsEmpty || _poolConfig.AllowEmptySnapshotBootstrap))
ShouldReconcileSnapshotFamily(
hasLocalActiveFamily,
localStateIsEmpty,
_poolConfig.AllowEmptySnapshotBootstrap))
{
return await TryReconcileSiblingSnapshotAsync(
bundle,
Expand Down Expand Up @@ -6370,6 +6372,14 @@ internal static int GetMaxImportedSnapshotContextCount(PoolConfig config)
return config.SnapshotProofSlotCount + config.WorkSetReserveLimit + 2;
}

internal static bool ShouldReconcileSnapshotFamily(
bool hasLocalActiveFamily,
bool localStateIsEmpty,
bool allowEmptySnapshotBootstrap)
{
return hasLocalActiveFamily && (!localStateIsEmpty || allowEmptySnapshotBootstrap);
}

private int RepairMissingWorkSetSnapshotContextsNoLock(DateTime nowUtc)
{
HashSet<string> existingContextIds = _state.SnapshotContexts
Expand Down
Loading