Remove userId from filter-server call#165
Conversation
📝 WalkthroughWalkthroughThe PR removes the ChangesRemove userId from filter-based contingency list flow
Dependency version management
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pom.xml (1)
49-50: ⚖️ Poor tradeoffEnsure the temporary dependency override doesn't persist beyond the gridsuite-dependencies upgrade.
The FIXME comments at lines 49-50 and 89-96 correctly flag this version override as temporary. Create a tracking issue to ensure it's removed when gridsuite-dependencies is upgraded from 50.1.0. The FilterAttributes API changes are evident in the codebase (constructor simplification and userId removal are in active use), confirming the override is necessary for current compatibility.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pom.xml` around lines 49 - 50, Add a tracking issue to remove the temporary gridsuite-actions.version override (the <gridsuite-actions.version> property set to 0.7.0) once gridsuite-dependencies is upgraded from 50.1.0; reference the FIXME comment currently adjacent to that property, note that the override exists to accommodate FilterAttributes API changes (constructor simplification and removal of userId), and include acceptance criteria in the issue to remove the override, run unit/integration tests that exercise FilterAttributes usage, and verify compilation against the upgraded gridsuite-dependencies.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@pom.xml`:
- Around line 49-50: Add a tracking issue to remove the temporary
gridsuite-actions.version override (the <gridsuite-actions.version> property set
to 0.7.0) once gridsuite-dependencies is upgraded from 50.1.0; reference the
FIXME comment currently adjacent to that property, note that the override exists
to accommodate FilterAttributes API changes (constructor simplification and
removal of userId), and include acceptance criteria in the issue to remove the
override, run unit/integration tests that exercise FilterAttributes usage, and
verify compilation against the upgraded gridsuite-dependencies.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b279893e-2bb2-494c-8fbf-3775b2261797
📒 Files selected for processing (5)
pom.xmlsrc/main/java/org/gridsuite/actions/server/ContingencyListController.javasrc/main/java/org/gridsuite/actions/server/ContingencyListService.javasrc/main/java/org/gridsuite/actions/server/service/FilterService.javasrc/test/java/org/gridsuite/actions/server/ContingencyListControllerTest.java
|



PR Summary
This PR updates the
actions-serverso that it no longer sends theuserIdbody parameter when calling certainfilter-serverendpoints, as it is no longer required.