Skip to content

checkstyleparent27#168

Merged
EtienneLt merged 4 commits into
mainfrom
checkstyleparent27
Jun 3, 2026
Merged

checkstyleparent27#168
EtienneLt merged 4 commits into
mainfrom
checkstyleparent27

Conversation

@jonenst

@jonenst jonenst commented May 29, 2026

Copy link
Copy Markdown
Contributor
  • parent27
  • Checkstyle parent27 mostly cosmetic changes (opus4.6 assisted)

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 34a04589-2b7f-4d78-a421-2d6dd6604240

📥 Commits

Reviewing files that changed from the base of the PR and between 3ff5121 and a0ed019.

📒 Files selected for processing (10)
  • pom.xml
  • src/main/java/org/gridsuite/actions/server/ContingencyListController.java
  • src/main/java/org/gridsuite/actions/server/ContingencyListService.java
  • src/main/java/org/gridsuite/actions/server/NotificationService.java
  • src/main/java/org/gridsuite/actions/server/entities/EquipmentTypesByFilterEntity.java
  • src/main/java/org/gridsuite/actions/server/entities/IdBasedContingencyListEntity.java
  • src/main/java/org/gridsuite/actions/server/entities/IdentifierListEntity.java
  • src/main/java/org/gridsuite/actions/server/repositories/IdBasedContingencyListRepository.java
  • src/test/java/org/gridsuite/actions/server/ContingencyListControllerTest.java
  • src/test/java/org/gridsuite/actions/server/SupervisionControllerTest.java

📝 Walkthrough

Walkthrough

Parent POM version upgraded from 26.1 to 28, and import statements, Javadoc author email formatting, annotation whitespace, and test exception suppression are normalized across production and test files.

Changes

Infrastructure and Code Cleanup

Layer / File(s) Summary
Parent POM version update
pom.xml
Maven parent version bumped to 28.
Controller and service cleanup
src/main/java/org/gridsuite/actions/server/ContingencyListController.java, src/main/java/org/gridsuite/actions/server/ContingencyListService.java
Imports reordered and annotation whitespace adjusted in controller and service files without changing behavior.
Notification service import reordering
src/main/java/org/gridsuite/actions/server/NotificationService.java
Java time and utility imports reordered after framework/logging imports.
Entity and repository documentation and formatting
src/main/java/org/gridsuite/actions/server/entities/EquipmentTypesByFilterEntity.java, src/main/java/org/gridsuite/actions/server/entities/IdBasedContingencyListEntity.java, src/main/java/org/gridsuite/actions/server/entities/IdentifierListEntity.java, src/main/java/org/gridsuite/actions/server/repositories/IdBasedContingencyListRepository.java
Javadoc author email formats normalized to spaced notation, imports organized, and annotation formatting adjusted across entity and repository classes.
Test code import and exception handling cleanup
src/test/java/org/gridsuite/actions/server/ContingencyListControllerTest.java, src/test/java/org/gridsuite/actions/server/SupervisionControllerTest.java
Imports reordered, try/catch/finally exception suppression removed from assertQueuesEmptyThenClear, and test helper method formatting adjusted.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'checkstyleparent27' is vague and does not clearly convey what changes were made; it appears to be a branch name rather than a descriptive pull request title. Use a more descriptive title that explains the main changes, such as 'Upgrade parent version to 28 and apply checkstyle formatting' or 'Update to parent 28 with cosmetic checkstyle improvements'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description mentions parent version updates and checkstyle changes, which aligns with the actual changeset involving parent version upgrade and import/formatting reorganization.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

jonenst and others added 2 commits June 2, 2026 13:45
Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

@EtienneLt EtienneLt self-requested a review June 2, 2026 12:36
@EtienneLt EtienneLt merged commit 932ad27 into main Jun 3, 2026
5 checks passed
@EtienneLt EtienneLt deleted the checkstyleparent27 branch June 3, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants