Skip to content

fix checkstyle#169

Merged
GhilesA merged 1 commit into
mainfrom
fix-checkstyle
Jun 4, 2026
Merged

fix checkstyle#169
GhilesA merged 1 commit into
mainfrom
fix-checkstyle

Conversation

@EtienneLt

Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this Jun 4, 2026
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c7ccf9fe-4d18-46d8-b49d-3da612537816

📥 Commits

Reviewing files that changed from the base of the PR and between 932ad27 and 6a33f65.

📒 Files selected for processing (1)
  • src/test/java/org/gridsuite/actions/server/ContingencyListControllerTest.java

📝 Walkthrough

Walkthrough

The PR refactors a test utility method to improve test robustness by ensuring queue cleanup always occurs, even when assertions fail. The assertQueuesEmptyThenClear method now wraps the queue-emptiness checks in a try block with output clearing moved to a finally block.

Changes

Test Queue Assertion Cleanup

Layer / File(s) Summary
Assert-and-clear utility method robustness
src/test/java/org/gridsuite/actions/server/ContingencyListControllerTest.java
The assertQueuesEmptyThenClear method refactored to use try/finally structure, guaranteeing output.clear() is called after queue assertions regardless of whether the assertions pass or fail.
🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'fix checkstyle' is vague and generic, using a non-descriptive term that doesn't convey meaningful information about what checkstyle issue was fixed. Replace the generic title with a more specific description of the checkstyle fix, such as 'Ensure output cleanup in assertQueuesEmptyThenClear even on assertion failure'.
Description check ❓ Inconclusive The PR description is empty with only a template header, providing no meaningful information about the changes or their rationale. Fill in the PR description with details about what checkstyle issue was being addressed and why the changes were necessary.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

@EtienneLt EtienneLt requested a review from GhilesA June 4, 2026 06:21

@GhilesA GhilesA left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the greatest achievement in humankind

@GhilesA GhilesA merged commit f557c74 into main Jun 4, 2026
5 checks passed
@GhilesA GhilesA deleted the fix-checkstyle branch June 4, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants