Skip to content

use key fors commons translations#1218

Open
JacquesBorsenberger wants to merge 3 commits into
mainfrom
chore_normalize_translation
Open

use key fors commons translations#1218
JacquesBorsenberger wants to merge 3 commits into
mainfrom
chore_normalize_translation

Conversation

@JacquesBorsenberger

Copy link
Copy Markdown
Contributor

PR Summary

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Two validation helpers were updated to use the shared YUP_REQUIRED constant instead of the hardcoded 'YupRequired' string for missing-field validation errors.

Changes

Yup required message normalization

Layer / File(s) Summary
Connectivity schema message update
src/features/network-modifications/common/connectivity/connectivityForm.utils.ts
Imports YUP_REQUIRED and uses it in the Yup .test required-field message.
Reactive capability message update
src/features/network-modifications/common/reactiveLimits/reactiveCapabilityCurve/reactiveCapability.utils.ts
Imports YUP_REQUIRED and uses it as the Yup error message when reactive capability curve fields are missing.

Suggested reviewers: thangqp, TheMaskedTurtle

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is only a placeholder and does not summarize the actual changes. Replace the placeholder with a brief summary of the shared YupRequired key updates and affected files.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title broadly matches the change to replace hardcoded validation strings with a shared translation key.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: BORSENBERGER Jacques <jacques.borsenberger@rte-france.com>
@JacquesBorsenberger JacquesBorsenberger force-pushed the chore_normalize_translation branch from fa2940a to 9ea9632 Compare June 30, 2026 07:32
JacquesBorsenberger and others added 2 commits July 2, 2026 14:23
Signed-off-by: BORSENBERGER Jacques <jacques.borsenberger@rte-france.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@JacquesBorsenberger JacquesBorsenberger changed the title WIP use key fors commons translations use key fors commons translations Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant