Skip to content

[FIX] LF, SA, SENSI, SC, NETWORK, PCC, VL params dialogs crashed or not stable#1229

Open
thangqp wants to merge 2 commits into
mainfrom
fix_params_dialogs_crash
Open

[FIX] LF, SA, SENSI, SC, NETWORK, PCC, VL params dialogs crashed or not stable#1229
thangqp wants to merge 2 commits into
mainfrom
fix_params_dialogs_crash

Conversation

@thangqp

@thangqp thangqp commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: Thang PHAM <phamthang37@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Six parameter dialogs now show a MUI LinearProgress indicator until their loading or initialization flags are set, and render the corresponding form only after that state is ready.

Changes

Conditional loading indicators for parameter dialogs

Layer / File(s) Summary
Load flow dialog loading state
src/features/parameters/loadflow/load-flow-parameters-dialog.tsx
Imports LinearProgress and conditionally renders LoadFlowParametersForm only when loadflowMethods.paramsLoaded is true.
Security analysis dialog loading state
src/features/parameters/security-analysis/security-analysis-parameters-dialog.tsx
Imports LinearProgress and conditionally renders SecurityAnalysisParametersForm based on securityAnalysisMethods.paramsFormInitialized.
Sensitivity analysis dialog loading state
src/features/parameters/sensi/sensitivity-analysis-parameters-dialog.tsx
Imports LinearProgress and conditionally renders SensitivityAnalysisParametersForm based on sensitivityAnalysisMethods.paramsFormInitialized.
Network visualizations dialog loading state
src/features/parameters/network-visualizations/network-visualizations-parameters-dialog.tsx
Imports LinearProgress and conditionally renders NetworkVisualizationParametersForm based on networkVisuMethods.paramsLoading.
PCC Min dialog loading state
src/features/parameters/pcc-min/pcc-min-parameters-dialog.tsx
Imports LinearProgress and conditionally renders PccMinParametersForm based on pccMinMethods.paramsLoading.
Short-circuit and voltage-init loading states
src/features/parameters/short-circuit/short-circuit-parameters-dialog.tsx, src/features/parameters/voltage-init/voltage-init-parameters-dialog.tsx
Imports LinearProgress and conditionally renders each form based on its loading flag.
Suggested reviewers: flomillot, ayolab, TheMaskedTurtle
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main fix: delaying unstable parameter dialogs until their params are loaded.
Description check ✅ Passed The description is directly about preventing forms from rendering before parameters are loaded, which matches the changes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Thang PHAM <phamthang37@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@thangqp thangqp changed the title [FIX] LF, SA, SENSI Params dialogs crashed or not stable [FIX] LF, SA, SENSI, SC, NETWORK, PCC, VL params dialogs crashed or not stable Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant