Migrate to grid2#192
Conversation
|
Warning Review limit reached
Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR migrates app shell, shared components, and multiple page layouts from MUI Grid v1 to Grid2 or Box/Stack wrappers. It also updates grid sizing props to ChangesMUI Grid to Grid2/Box Migration
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
5cc5959 to
fe8240e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/App/App.tsx`:
- Line 143: The App shell in App should not use 100vw because it can overflow
when the vertical scrollbar is present; update the top-level Box styling to use
width: '100%' instead while keeping the existing flex column layout and
full-height behavior. Use the App component’s outer Box as the fix location.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d6c11f1c-785c-4b54-9d74-45cd7cc15c69
📒 Files selected for processing (15)
src/components/App/App.tsxsrc/components/App/HomePage.tsxsrc/components/Grid/GridTable.tsxsrc/pages/announcements/add-announcement-form.tsxsrc/pages/announcements/announcements-page.tsxsrc/pages/common/multi-chip-cell-renderer.tsxsrc/pages/common/table-selection.tsxsrc/pages/groups/groups-page.tsxsrc/pages/groups/modification/group-modification-form.tsxsrc/pages/profiles/modification/configuration-selection.tsxsrc/pages/profiles/modification/profile-modification-form.tsxsrc/pages/profiles/profiles-page.tsxsrc/pages/profiles/validity-cell-renderer.tsxsrc/pages/users/modification/user-modification-form.tsxsrc/pages/users/users-page.tsx
There was a problem hiding this comment.
Pull request overview
This PR migrates multiple pages/components from MUI Grid to Grid2 (and in several places to Stack/Box) to support the ongoing Grid2 migration and simplify some layouts.
Changes:
- Replace
@mui/material/Gridusages withGrid2 as Grid, updating sizing props (xs/item) tosize/ Grid2 patterns. - Refactor several “full-height” column layouts from nested Grids to
Stack+BoxwithflexGrow. - Simplify
ValidityCellRendererby returning icons directly (removing the Grid wrapper).
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/users/users-page.tsx | Switch page layout wrapper from Grid to Stack + Grid2 container. |
| src/pages/users/modification/user-modification-form.tsx | Migrate form container/items to Grid2 and sx layout. |
| src/pages/profiles/validity-cell-renderer.tsx | Remove Grid wrapper and return icon elements directly. |
| src/pages/profiles/profiles-page.tsx | Switch page layout wrapper from Grid to Stack + Grid2 container. |
| src/pages/profiles/modification/profile-modification-form.tsx | Migrate form layout to Grid2 and size props where needed. |
| src/pages/profiles/modification/configuration-selection.tsx | Migrate Grid usage to Grid2 and update xs to size. |
| src/pages/groups/modification/group-modification-form.tsx | Migrate form container/items to Grid2 and sx layout. |
| src/pages/groups/groups-page.tsx | Switch page layout wrapper from Grid to Stack + Grid2 container. |
| src/pages/common/table-selection.tsx | Replace Grid column layout with Stack/Box around the AG Grid. |
| src/pages/common/multi-chip-cell-renderer.tsx | Migrate chip layout container from Grid to Grid2. |
| src/pages/announcements/announcements-page.tsx | Migrate columns layout to Grid2 with Stack/Box wrappers. |
| src/pages/announcements/add-announcement-form.tsx | Refactor form layout from Grid to Stack + Grid2 and Box. |
| src/components/Grid/GridTable.tsx | Replace Grid column layout with Stack/Box around toolbar + AgGrid. |
| src/components/App/HomePage.tsx | Migrate single Grid item to Grid2 (size). |
| src/components/App/App.tsx | Replace top-level Grid layout with flex Box column layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FranckLecuyer
left a comment
There was a problem hiding this comment.
Test: just helper text in user/group/profile modification dialogs partially hidden ...
e46bf29 to
9e16cb3
Compare
|



PR Summary