Skip to content

Migrate to grid2#192

Merged
antoinebhs merged 14 commits into
mainfrom
migrate-to-grid2
Jul 3, 2026
Merged

Migrate to grid2#192
antoinebhs merged 14 commits into
mainfrom
migrate-to-grid2

Conversation

@antoinebhs

Copy link
Copy Markdown
Contributor

PR Summary

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@antoinebhs, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 59221940-c5ac-4cdd-abce-cdde77707eda

📥 Commits

Reviewing files that changed from the base of the PR and between 1a40d14 and 9e16cb3.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json
📝 Walkthrough

Walkthrough

The PR migrates app shell, shared components, and multiple page layouts from MUI Grid v1 to Grid2 or Box/Stack wrappers. It also updates grid sizing props to size and replaces several inline sizing styles with sx.

Changes

MUI Grid to Grid2/Box Migration

Layer / File(s) Summary
App shell and home layout
src/components/App/App.tsx, src/components/App/HomePage.tsx
App.tsx replaces its top-level Grid layout with a Box flex-column wrapper. HomePage.tsx switches to Grid2 and uses size={12} instead of item xs={12}.
Shared table layouts
src/components/Grid/GridTable.tsx, src/pages/common/multi-chip-cell-renderer.tsx, src/pages/common/table-selection.tsx
GridTable, TableSelection, and MultiChipCellRenderer remove legacy Grid wrappers in favor of Stack/Box-based layout or Grid2 sizing, and multi-chip-cell-renderer also adjusts chip spacing.
Announcements page and form
src/pages/announcements/add-announcement-form.tsx, src/pages/announcements/announcements-page.tsx
The announcements page and form switch to Grid2 sizing and reorganize their two-column and stacked form sections with Stack and Box wrappers.
Groups page and modification form
src/pages/groups/groups-page.tsx, src/pages/groups/modification/group-modification-form.tsx
Both group screens switch to Grid2 and replace nested item layouts with Stack-based full-height/full-width wrappers and sx sizing.
Profiles pages, forms, and cell renderer
src/pages/profiles/profiles-page.tsx, src/pages/profiles/modification/profile-modification-form.tsx, src/pages/profiles/modification/configuration-selection.tsx, src/pages/profiles/validity-cell-renderer.tsx
Profiles screens update Grid usage to Grid2 sizing, and ValidityCellRenderer replaces its Grid wrapper with a Box-based single-icon render path.
Users page and modification form
src/pages/users/users-page.tsx, src/pages/users/modification/user-modification-form.tsx
The users page and modification form switch to Grid2 and change nested layout wrappers to Stack and sx-based sizing.

Suggested reviewers: etiennehomer

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description is just a placeholder summary and does not describe the actual changes. Replace the placeholder with a brief summary of what changed, such as the Grid-to-Grid2 layout migration and related wrapper refactors.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: migrating layouts from Grid to Grid2.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/App/App.tsx`:
- Line 143: The App shell in App should not use 100vw because it can overflow
when the vertical scrollbar is present; update the top-level Box styling to use
width: '100%' instead while keeping the existing flex column layout and
full-height behavior. Use the App component’s outer Box as the fix location.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d6c11f1c-785c-4b54-9d74-45cd7cc15c69

📥 Commits

Reviewing files that changed from the base of the PR and between ee40f4f and 5cc5959.

📒 Files selected for processing (15)
  • src/components/App/App.tsx
  • src/components/App/HomePage.tsx
  • src/components/Grid/GridTable.tsx
  • src/pages/announcements/add-announcement-form.tsx
  • src/pages/announcements/announcements-page.tsx
  • src/pages/common/multi-chip-cell-renderer.tsx
  • src/pages/common/table-selection.tsx
  • src/pages/groups/groups-page.tsx
  • src/pages/groups/modification/group-modification-form.tsx
  • src/pages/profiles/modification/configuration-selection.tsx
  • src/pages/profiles/modification/profile-modification-form.tsx
  • src/pages/profiles/profiles-page.tsx
  • src/pages/profiles/validity-cell-renderer.tsx
  • src/pages/users/modification/user-modification-form.tsx
  • src/pages/users/users-page.tsx

Comment thread src/components/App/App.tsx

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates multiple pages/components from MUI Grid to Grid2 (and in several places to Stack/Box) to support the ongoing Grid2 migration and simplify some layouts.

Changes:

  • Replace @mui/material/Grid usages with Grid2 as Grid, updating sizing props (xs/item) to size / Grid2 patterns.
  • Refactor several “full-height” column layouts from nested Grids to Stack + Box with flexGrow.
  • Simplify ValidityCellRenderer by returning icons directly (removing the Grid wrapper).

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/pages/users/users-page.tsx Switch page layout wrapper from Grid to Stack + Grid2 container.
src/pages/users/modification/user-modification-form.tsx Migrate form container/items to Grid2 and sx layout.
src/pages/profiles/validity-cell-renderer.tsx Remove Grid wrapper and return icon elements directly.
src/pages/profiles/profiles-page.tsx Switch page layout wrapper from Grid to Stack + Grid2 container.
src/pages/profiles/modification/profile-modification-form.tsx Migrate form layout to Grid2 and size props where needed.
src/pages/profiles/modification/configuration-selection.tsx Migrate Grid usage to Grid2 and update xs to size.
src/pages/groups/modification/group-modification-form.tsx Migrate form container/items to Grid2 and sx layout.
src/pages/groups/groups-page.tsx Switch page layout wrapper from Grid to Stack + Grid2 container.
src/pages/common/table-selection.tsx Replace Grid column layout with Stack/Box around the AG Grid.
src/pages/common/multi-chip-cell-renderer.tsx Migrate chip layout container from Grid to Grid2.
src/pages/announcements/announcements-page.tsx Migrate columns layout to Grid2 with Stack/Box wrappers.
src/pages/announcements/add-announcement-form.tsx Refactor form layout from Grid to Stack + Grid2 and Box.
src/components/Grid/GridTable.tsx Replace Grid column layout with Stack/Box around toolbar + AgGrid.
src/components/App/HomePage.tsx Migrate single Grid item to Grid2 (size).
src/components/App/App.tsx Replace top-level Grid layout with flex Box column layout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/pages/announcements/announcements-page.tsx Outdated
Comment thread src/pages/common/table-selection.tsx Outdated
Comment thread src/components/Grid/GridTable.tsx Outdated
antoinebhs and others added 6 commits July 2, 2026 09:53
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@FranckLecuyer FranckLecuyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: just helper text in user/group/profile modification dialogs partially hidden ...

@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

@antoinebhs antoinebhs merged commit 3a98721 into main Jul 3, 2026
6 checks passed
@antoinebhs antoinebhs deleted the migrate-to-grid2 branch July 3, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants