Skip to content

Clear file state on equipment type change in tabular forms #4070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flomillot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clear file state on equipment type change in tabular forms #4070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c2a416
Clear file state on equipment type change in tabular forms
flomillot Jun 29, 2026
076576f
Remove CSV allowMissingColumns from tabular forms
flomillot Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions ...ponents/dialogs/network-modifications/limit-sets/limit-sets-tabular-modification-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,13 +193,16 @@ export function LimitSetsTabularModificationForm({ dataFetching }: Readonly<Tabu
return commentData;
}, [intl, csvTranslatedColumns, language]);

const handleChangeType = useCallback(() => {
clearErrors(MODIFICATIONS_TABLE);
tableRef.current?.replace([]);
const resetFileStateOnTypeChange = useCallback(() => {
setValue(CSV_FILENAME, undefined);
setSelectedFile(undefined);
setFileErrorMessage(undefined);
}, [clearErrors, setValue]);
}, [setValue]);

const resetFormStateOnTypeChange = useCallback(() => {
clearErrors(MODIFICATIONS_TABLE);
tableRef.current?.replace([]);
}, [clearErrors]);

const csvFilename = getValues(CSV_FILENAME);

Expand All @@ -225,7 +228,8 @@ export function LimitSetsTabularModificationForm({ dataFetching }: Readonly<Tabu
size={'small'}
formProps={{ variant: 'outlined' }}
shouldOpenPopup={() => hasNonEmptyRows(getValues(MODIFICATIONS_TABLE))}
resetOnConfirmation={handleChangeType}
resetOnChange={resetFileStateOnTypeChange}
resetOnConfirmation={resetFormStateOnTypeChange}
message="changeTypeMessage"
validateButtonLabel="button.changeType"
/>
Expand Down
14 changes: 9 additions & 5 deletions src/components/dialogs/network-modifications/tabular/tabular-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,14 +413,17 @@ export function TabularForm({ dataFetching, dialogMode }: Readonly<TabularFormPr
);
}, [dialogMode]);

const handleChangeType = useCallback(() => {
clearErrors(MODIFICATIONS_TABLE);
tableRef.current?.replace([]);
const resetFileStateOnTypeChange = useCallback(() => {
setValue(CSV_FILENAME, undefined);
setValue(TABULAR_PROPERTIES, []);
setSelectedFile(undefined);
setFileErrorMessage(undefined);
setFileWarningMessage(undefined);
}, [setValue]);

const resetFormStateOnTypeChange = useCallback(() => {
clearErrors(MODIFICATIONS_TABLE);
tableRef.current?.replace([]);
setValue(TABULAR_PROPERTIES, []);
}, [clearErrors, setValue]);

const equipmentTypeField = (
Expand All @@ -433,7 +436,8 @@ export function TabularForm({ dataFetching, dialogMode }: Readonly<TabularFormPr
size={'small'}
formProps={{ variant: 'outlined' }}
shouldOpenPopup={() => hasNonEmptyRows(getValues(MODIFICATIONS_TABLE))}
resetOnConfirmation={handleChangeType}
resetOnChange={resetFileStateOnTypeChange}
resetOnConfirmation={resetFormStateOnTypeChange}
message="changeTypeMessage"
validateButtonLabel="button.changeType"
/>
Expand Down
Loading