Skip to content

checkstyleparent27#93

Merged
antoinebhs merged 5 commits into
mainfrom
checkstyleparent27
Jun 26, 2026
Merged

checkstyleparent27#93
antoinebhs merged 5 commits into
mainfrom
checkstyleparent27

Conversation

@jonenst

@jonenst jonenst commented May 29, 2026

Copy link
Copy Markdown
Contributor
  • parent27
  • Checkstyle parent27 mostly cosmetic changes (opus4.6 assisted)

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f9e61dcd-3ea2-4fc3-8469-ef1a3b57d849

📥 Commits

Reviewing files that changed from the base of the PR and between 3728359 and 0425e04.

📒 Files selected for processing (6)
  • monitor-server/src/main/java/org/gridsuite/monitor/server/controllers/ProcessConfigController.java
  • monitor-server/src/main/java/org/gridsuite/monitor/server/services/processconfig/ProcessConfigService.java
  • monitor-server/src/test/java/org/gridsuite/monitor/server/controllers/ProcessConfigControllerTest.java
  • monitor-server/src/test/java/org/gridsuite/monitor/server/services/processconfig/LoadFlowConfigHandlerTest.java
  • monitor-server/src/test/java/org/gridsuite/monitor/server/services/processconfig/ProcessConfigServiceTest.java
  • monitor-worker-server/src/main/resources/org/gridsuite/monitor/worker/server/reports_fr.properties
✅ Files skipped from review due to trivial changes (5)
  • monitor-server/src/test/java/org/gridsuite/monitor/server/services/processconfig/ProcessConfigServiceTest.java
  • monitor-server/src/main/java/org/gridsuite/monitor/server/services/processconfig/ProcessConfigService.java
  • monitor-server/src/test/java/org/gridsuite/monitor/server/services/processconfig/LoadFlowConfigHandlerTest.java
  • monitor-server/src/main/java/org/gridsuite/monitor/server/controllers/ProcessConfigController.java
  • monitor-server/src/test/java/org/gridsuite/monitor/server/controllers/ProcessConfigControllerTest.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • monitor-worker-server/src/main/resources/org/gridsuite/monitor/worker/server/reports_fr.properties

📝 Walkthrough

Walkthrough

This PR updates import ordering across monitor-core modules, changes Severity.fromValue() null and exception handling, adds French worker-server report keys, and updates the Maven parent version and .gitignore IntelliJ module pattern.

Changes

Code cleanup and import organization

Layer / File(s) Summary
Project configuration and gitignore
pom.xml, .gitignore
The Maven parent version changes from 26.1 to 28, and the IntelliJ module ignore rule broadens from a root-only pattern to a global *.iml pattern.
Severity error handling update
monitor-server/src/main/java/org/gridsuite/monitor/server/dto/report/Severity.java
fromValue() now returns UNKNOWN for null input and catches only IllegalArgumentException from valueOf.
Commons and server imports
monitor-commons/src/main/java/org/gridsuite/monitor/commons/types/messaging/ProcessExecutionStep.java, monitor-commons/src/main/java/org/gridsuite/monitor/commons/types/messaging/ProcessRunMessage.java, monitor-server/src/main/java/org/gridsuite/monitor/server/controllers/ProcessConfigController.java, monitor-server/src/main/java/org/gridsuite/monitor/server/entities/processconfig/ProcessConfigEntity.java, monitor-server/src/main/java/org/gridsuite/monitor/server/entities/processexecution/ProcessExecutionStepEntity.java, monitor-server/src/main/java/org/gridsuite/monitor/server/messaging/NotificationService.java, monitor-server/src/main/java/org/gridsuite/monitor/server/services/processconfig/ProcessConfigService.java, monitor-server/src/main/java/org/gridsuite/monitor/server/services/result/providers/SecurityAnalysisResultProvider.java
Import blocks are reordered across commons and server main code, including process messaging types, process config entity imports, process execution step imports, controller/service imports, and notification/result provider imports.
Worker-server imports, tests, and resources
monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/config/MonitorWorkerConfig.java, monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/orchestrator/ProcessExecutionService.java, monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/orchestrator/StepExecutionService.java, monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/process/commons/steps/ApplyModificationsStep.java, monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/process/commons/steps/LoadNetworkStep.java, monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/process/securityanalysis/steps/SecurityAnalysisRunComputationStep.java, monitor-worker-server/src/main/resources/org/gridsuite/monitor/worker/server/reports.properties, monitor-worker-server/src/main/resources/org/gridsuite/monitor/worker/server/reports_fr.properties, monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/clients/NetworkModificationRestClientTest.java, monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/core/process/AbstractProcessTest.java, monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/messaging/ConsumerServiceTest.java, monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/orchestrator/StepExecutionServiceTest.java, monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/process/securityanalysis/steps/SecurityAnalysisRunComputationStepTest.java, monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/services/FilterServiceTest.java
Worker-server main imports are reordered, tests are reformatted with grouped imports and multiline constructor/request expectations, and French report keys are added alongside reordered English report properties.
Server and worker test imports
monitor-server/src/test/java/org/gridsuite/monitor/server/MonitorIntegrationTest.java, monitor-server/src/test/java/org/gridsuite/monitor/server/controllers/MonitorControllerTest.java, monitor-server/src/test/java/org/gridsuite/monitor/server/controllers/ProcessConfigControllerTest.java, monitor-server/src/test/java/org/gridsuite/monitor/server/services/processconfig/LoadFlowConfigHandlerTest.java, monitor-server/src/test/java/org/gridsuite/monitor/server/services/processconfig/ProcessConfigServiceTest.java, monitor-server/src/test/java/org/gridsuite/monitor/server/services/processexecution/ProcessExecutionTxServiceTest.java
Server tests update import grouping and multiline formatting for process execution fixtures, controller expectations, and process-config test setup.

Suggested reviewers

  • antoinebhs
  • khouadrired
  • FranckLecuyer
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is too vague and branch-like to clearly describe the changeset. Use a concise title that names the main change, such as updating the parent POM version or checkstyle parent configuration.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is brief, but it is still related to the mostly cosmetic checkstyle parent changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GhilesA GhilesA self-assigned this Jun 2, 2026
@GhilesA GhilesA self-requested a review June 2, 2026 11:54
@GhilesA GhilesA force-pushed the checkstyleparent27 branch 4 times, most recently from fed9a2a to 68da4f4 Compare June 3, 2026 13:29
@GhilesA GhilesA force-pushed the checkstyleparent27 branch from 68da4f4 to 5ee085e Compare June 3, 2026 15:01
@GhilesA GhilesA force-pushed the checkstyleparent27 branch from 5ee085e to 3728359 Compare June 4, 2026 08:05

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@monitor-worker-server/src/main/resources/org/gridsuite/monitor/worker/server/reports_fr.properties`:
- Around line 1-7: The French resource bundle entries for keys
monitor.worker.server.importCase, monitor.worker.server.loadflow.step.error,
monitor.worker.server.modifications.error, monitor.worker.server.process,
monitor.worker.server.securityanalysis.step.error,
monitor.worker.server.step.execution and monitor.worker.server.stepType are
empty; update each key with a non-empty French string (or a temporary English
fallback) so runtime labels aren't blank—e.g. provide translations like
"Importer le cas" for monitor.worker.server.importCase and similar meaningful
values for the other keys, save the properties file with UTF-8 encoding, and
verify keys match exactly those in the code that reads them (e.g., report node
templates referencing monitor.worker.server.*).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b32fb3ae-7cbe-463f-b921-79c4c23be928

📥 Commits

Reviewing files that changed from the base of the PR and between ab90104 and 3728359.

📒 Files selected for processing (30)
  • .gitignore
  • monitor-commons/src/main/java/org/gridsuite/monitor/commons/types/messaging/ProcessExecutionStep.java
  • monitor-commons/src/main/java/org/gridsuite/monitor/commons/types/messaging/ProcessRunMessage.java
  • monitor-server/src/main/java/org/gridsuite/monitor/server/controllers/ProcessConfigController.java
  • monitor-server/src/main/java/org/gridsuite/monitor/server/dto/report/Severity.java
  • monitor-server/src/main/java/org/gridsuite/monitor/server/entities/processconfig/ProcessConfigEntity.java
  • monitor-server/src/main/java/org/gridsuite/monitor/server/entities/processexecution/ProcessExecutionStepEntity.java
  • monitor-server/src/main/java/org/gridsuite/monitor/server/messaging/NotificationService.java
  • monitor-server/src/main/java/org/gridsuite/monitor/server/services/processconfig/ProcessConfigService.java
  • monitor-server/src/main/java/org/gridsuite/monitor/server/services/result/providers/SecurityAnalysisResultProvider.java
  • monitor-server/src/test/java/org/gridsuite/monitor/server/MonitorIntegrationTest.java
  • monitor-server/src/test/java/org/gridsuite/monitor/server/controllers/MonitorControllerTest.java
  • monitor-server/src/test/java/org/gridsuite/monitor/server/controllers/ProcessConfigControllerTest.java
  • monitor-server/src/test/java/org/gridsuite/monitor/server/services/processconfig/ProcessConfigServiceTest.java
  • monitor-server/src/test/java/org/gridsuite/monitor/server/services/processexecution/ProcessExecutionTxServiceTest.java
  • monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/config/MonitorWorkerConfig.java
  • monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/orchestrator/ProcessExecutionService.java
  • monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/orchestrator/StepExecutionService.java
  • monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/process/commons/steps/ApplyModificationsStep.java
  • monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/process/commons/steps/LoadNetworkStep.java
  • monitor-worker-server/src/main/java/org/gridsuite/monitor/worker/server/process/securityanalysis/steps/SecurityAnalysisRunComputationStep.java
  • monitor-worker-server/src/main/resources/org/gridsuite/monitor/worker/server/reports.properties
  • monitor-worker-server/src/main/resources/org/gridsuite/monitor/worker/server/reports_fr.properties
  • monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/clients/NetworkModificationRestClientTest.java
  • monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/core/process/AbstractProcessTest.java
  • monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/messaging/ConsumerServiceTest.java
  • monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/orchestrator/StepExecutionServiceTest.java
  • monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/process/securityanalysis/steps/SecurityAnalysisRunComputationStepTest.java
  • monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/services/FilterServiceTest.java
  • pom.xml
💤 Files with no reviewable changes (1)
  • monitor-worker-server/src/test/java/org/gridsuite/monitor/worker/server/core/process/AbstractProcessTest.java

EtienneLt and others added 2 commits June 9, 2026 13:31
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
# Conflicts:
#	monitor-server/src/main/java/org/gridsuite/monitor/server/services/processconfig/ProcessConfigService.java
#	monitor-server/src/test/java/org/gridsuite/monitor/server/services/processconfig/ProcessConfigServiceTest.java
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@antoinebhs antoinebhs merged commit 565c882 into main Jun 26, 2026
3 of 4 checks passed
@antoinebhs antoinebhs deleted the checkstyleparent27 branch June 26, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants