Skip to content

Fix process configs duplicate endpoint #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carojeandat wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

Fix process configs duplicate endpoint #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd8cf0e
Fix process configs duplicate endpoint
carojeandat Jun 12, 2026
17518b9
Merge branch 'main' into caroline/fix-process-configs-duplicate-endpoint
carojeandat Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...erver/src/main/java/org/gridsuite/monitor/server/controllers/ProcessConfigController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,13 @@ public ResponseEntity<Void> updateProcessConfig(
return processConfigUpdated.isPresent() ? ResponseEntity.ok().build() : ResponseEntity.notFound().build();
}

@PostMapping(value = "", params = "duplicateFrom", produces = MediaType.APPLICATION_JSON_VALUE)
@PostMapping(value = "/{uuid}/duplicate", produces = MediaType.APPLICATION_JSON_VALUE)
@Operation(summary = "Duplicate a process config")
@ApiResponses(value = {
@ApiResponse(responseCode = "200", description = "process config was duplicated"),
@ApiResponse(responseCode = "404", description = "process config to duplicate was not found")})
public ResponseEntity<UUID> duplicateProcessConfig(
@Parameter(description = "UUID of the process config to duplicate") @RequestParam("duplicateFrom") UUID sourceProcessConfigUuid) {
@Parameter(description = "UUID of the process config to duplicate") @PathVariable("uuid") UUID sourceProcessConfigUuid) {
Optional<UUID> newProcessConfigUuid = processConfigService.duplicateProcessConfig(sourceProcessConfigUuid);
return newProcessConfigUuid
.map(configUuid -> ResponseEntity.ok().body(configUuid))
Expand Down
4 changes: 2 additions & 2 deletions ...r/src/test/java/org/gridsuite/monitor/server/controllers/ProcessConfigControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ void duplicateProcessConfig() throws Exception {
when(processConfigService.duplicateProcessConfig(processConfigId))
.thenReturn(Optional.of(newProcessConfigId));

mockMvc.perform(post("/v1/process-configs?duplicateFrom={uuid}", processConfigId))
mockMvc.perform(post("/v1/process-configs/{uuid}/duplicate", processConfigId))
.andExpect(status().isOk())
.andExpect(content().contentType(MediaType.APPLICATION_JSON))
.andExpect(jsonPath("$").value(newProcessConfigId.toString()));
Expand All @@ -184,7 +184,7 @@ void duplicateProcessConfigNotFound() throws Exception {
when(processConfigService.duplicateProcessConfig(processConfigId))
.thenReturn(Optional.empty());

mockMvc.perform(post("/v1/process-configs?duplicateFrom={uuid}", processConfigId))
mockMvc.perform(post("/v1/process-configs/{uuid}/duplicate", processConfigId))
.andExpect(status().isNotFound());

verify(processConfigService).duplicateProcessConfig(processConfigId);
Expand Down
Loading