Skip to content

Fix on strategy pattern implementation#97

Merged
carojeandat merged 1 commit into
mainfrom
caroline/fix-strategy-pattern
Jun 26, 2026
Merged

Fix on strategy pattern implementation#97
carojeandat merged 1 commit into
mainfrom
caroline/fix-strategy-pattern

Conversation

@carojeandat

Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: Caroline Jeandat <caroline.jeandat@rte-france.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7272d45b-8f42-4f2d-83b8-b8a17868637e

📥 Commits

Reviewing files that changed from the base of the PR and between 07728df and afae7e7.

📒 Files selected for processing (1)
  • monitor-server/src/main/java/org/gridsuite/monitor/server/controllers/ProcessConfigController.java

📝 Walkthrough

Walkthrough

ProcessConfigController.compareProcessConfigs now returns 200 OK when the comparison is present and 404 NOT_FOUND when it is absent. The previous ClassCastException handling that returned 400 BAD_REQUEST was removed.

Changes

Process config comparison response handling

Layer / File(s) Summary
Direct Optional-to-response mapping
monitor-server/src/main/java/org/gridsuite/monitor/server/controllers/ProcessConfigController.java
compareProcessConfigs now derives the HTTP response directly from the service Optional, returning 200 OK or 404 NOT_FOUND and no longer catching ClassCastException to return 400 BAD_REQUEST.

Suggested reviewers

  • khouadrired
🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is related to the change, but it is too generic to clearly identify the main update. Use a specific title that names the affected component and behavior change.
Description check ❓ Inconclusive The description is only a template placeholder and does not describe the actual changes. Replace the placeholder with a brief summary of what changed and why.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@carojeandat carojeandat merged commit 62e5569 into main Jun 26, 2026
5 checks passed
@carojeandat carojeandat deleted the caroline/fix-strategy-pattern branch June 26, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants