Skip to content

Fix nested composite cut operations#841

Open
Meklo wants to merge 3 commits into
mainfrom
marcellinh/fix_nested_composite_cut
Open

Fix nested composite cut operations#841
Meklo wants to merge 3 commits into
mainfrom
marcellinh/fix_nested_composite_cut

Conversation

@Meklo

@Meklo Meklo commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

PR Summary

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 554280e2-eda3-4971-be74-431b003a4d0d

📥 Commits

Reviewing files that changed from the base of the PR and between 4776b96 and 05db9be.

📒 Files selected for processing (1)
  • src/main/java/org/gridsuite/modification/server/service/NetworkModificationService.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/main/java/org/gridsuite/modification/server/service/NetworkModificationService.java

📝 Walkthrough

Walkthrough

moveModifications now always creates a mutable child set before removing selected composite UUIDs, so the later filtering step can run in both empty and non-empty selection cases.

Changes

Network modification child selection

Layer / File(s) Summary
Mutable children set
src/main/java/org/gridsuite/modification/server/service/NetworkModificationService.java
childrenOfSelectedComposites is wrapped in a mutable HashSet before removeAll(selectedCompositeUuids) runs, while keeping the same child-resolution and sub-modification UUID logic.

Suggested reviewers

  • souissimai
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description is just a template placeholder and does not meaningfully describe the changeset. Replace the placeholder with a brief summary of what changed, why it changed, and any reviewer notes.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: fixing nested composite cut operations in network modifications.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@souissimai souissimai self-requested a review July 6, 2026 08:05
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@souissimai souissimai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and test OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants