Skip to content

remove Disconnector default value from create section #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EtienneLt wants to merge 3 commits into
base: main
Choose a base branch
from
Open

remove Disconnector default value from create section #202

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05d7b1a
remove Disconnector default value from create section
EtienneLt Jun 15, 2026
7c783eb
Merge branch 'main' into remove-default-value-for-createSection
EtienneLt Jun 17, 2026
b45c0a6
Merge branch 'main' into remove-default-value-for-createSection
etiennehomer Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/gridsuite/modification/modifications/CreateVoltageLevelSection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ public void apply(Network network, NamingStrategy namingStrategy, ReportNode sub
.withAllBusbars(modificationInfos.isAllBusbars())
.withLeftSwitchOpen(modificationInfos.isSwitchOpen())
.withRightSwitchOpen(modificationInfos.isSwitchOpen())
.withLeftSwitchKind(modificationInfos.getLeftSwitchKind() != null ? SwitchKind.valueOf(modificationInfos.getLeftSwitchKind()) : SwitchKind.DISCONNECTOR)
.withRightSwitchKind(modificationInfos.getRightSwitchKind() != null ? SwitchKind.valueOf(modificationInfos.getRightSwitchKind()) : SwitchKind.DISCONNECTOR)
.withLeftSwitchKind(modificationInfos.getLeftSwitchKind() != null ? SwitchKind.valueOf(modificationInfos.getLeftSwitchKind()) : null)
.withRightSwitchKind(modificationInfos.getRightSwitchKind() != null ? SwitchKind.valueOf(modificationInfos.getRightSwitchKind()) : null)
Comment on lines +87 to +88

@coderabbitai coderabbitai Bot Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a regression test for the new null switch-kind path.

This change intentionally alters defaulting semantics, but current referenced tests only cover explicit "BREAKER"/"DISCONNECTOR" inputs. Please add a test where leftSwitchKind and rightSwitchKind are omitted to lock the new contract (null propagated, no implicit DISCONNECTOR default).

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/main/java/org/gridsuite/modification/modifications/CreateVoltageLevelSection.java`
around lines 87 - 88, The code now allows null values for leftSwitchKind and
rightSwitchKind to be passed through to withLeftSwitchKind and
withRightSwitchKind methods without defaulting to DISCONNECTOR. Add a new
regression test case that omits these switch-kind fields entirely (leaving them
null) to verify that null values are properly propagated through the
CreateVoltageLevelSection modification and that no implicit DISCONNECTOR
defaulting occurs. This test should validate the new null-handling contract
alongside the existing tests that cover explicit BREAKER and DISCONNECTOR
values.

.withSwitchPrefixId(voltageLevel.getId())
.withBusbarSectionPrefixId(voltageLevel.getId())
.build();
Expand Down
Loading