Skip to content

change distance value type#207

Merged
EtienneLt merged 1 commit into
mainfrom
change-distance-value-type
Jul 1, 2026
Merged

change distance value type#207
EtienneLt merged 1 commit into
mainfrom
change-distance-value-type

Conversation

@EtienneLt

Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this Jul 1, 2026
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3c69ff09-48cb-4220-8052-5514a14479e4

📥 Commits

Reviewing files that changed from the base of the PR and between b6269fb and dbeaf83.

📒 Files selected for processing (5)
  • src/main/java/org/gridsuite/modification/dto/LineSegmentInfos.java
  • src/test/java/org/gridsuite/modification/modifications/LineCreationInBusBreakerTest.java
  • src/test/java/org/gridsuite/modification/modifications/LineCreationInMixedTypologyTest.java
  • src/test/java/org/gridsuite/modification/modifications/LineCreationInNodeBreakerTest.java
  • src/test/java/org/gridsuite/modification/modifications/LineModificationTest.java

📝 Walkthrough

Walkthrough

The segmentDistanceValue field type in the LineSegmentInfos record is changed from Integer to Double. Corresponding test fixtures in four test classes are updated to pass 1.0 instead of 1 when constructing LineSegmentInfos instances, with minor list formatting adjustments.

Changes

Segment distance type change

Layer / File(s) Summary
Record component type update
src/main/java/org/gridsuite/modification/dto/LineSegmentInfos.java
The segmentDistanceValue component type changes from Integer to Double in the LineSegmentInfos record.
Test fixture numeric literal updates
src/test/java/org/gridsuite/modification/modifications/LineCreationInBusBreakerTest.java, LineCreationInMixedTypologyTest.java, LineCreationInNodeBreakerTest.java, LineModificationTest.java
lineSegments test data in buildModification() methods is updated to pass 1.0 instead of 1 for LineSegmentInfos numeric arguments, with related List.of(...) formatting adjustments.

Suggested reviewers: flomillot

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is just a placeholder and does not meaningfully describe the changeset. Replace the placeholder with a brief summary of the type change and the affected files or tests.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: updating the distance value type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@EtienneLt EtienneLt merged commit 732844f into main Jul 1, 2026
5 checks passed
@EtienneLt EtienneLt deleted the change-distance-value-type branch July 1, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants