Skip to content

fix: serialize tool-only Chat Completions content - #10

Merged
grikomsn merged 1 commit into
mainfrom
codex/fix-deepseek-tool-content
Aug 20, 2026
Merged

fix: serialize tool-only Chat Completions content#10
grikomsn merged 1 commit into
mainfrom
codex/fix-deepseek-tool-content

Conversation

@grikomsn

@grikomsn grikomsn commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • serialize textless Chat Completions messages with content: "" instead of null
  • preserve existing text/image content-part behavior
  • add regression coverage and a patch changeset

Fixes #8

Verification

  • npm run check — 71 tests passed
  • npm run package — VSIX packaging passed
  • sideloaded 0.4.0 into VS Code 1.134.0
  • live OpenCode Go inference succeeded with MiniMax-M3

The current VS Code profile exposes the Go credential through the extension’s management command rather than as a selectable Go chat-model entry, so the exact DeepSeek tool-roundtrip was validated through the focused serialization regression test.

@grikomsn grikomsn self-assigned this Aug 20, 2026
@grikomsn
grikomsn marked this pull request as ready for review August 20, 2026 19:10

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes This review covers the shared content normalization, downstream request serialization, regression tests, and changeset; local npm test passes all 71 tests.

  • Content normalization — textless Chat Completions messages now serialize with an empty string while existing text and image content-part shapes remain unchanged.
  • Provider integration — the shared type/helper refactor is compatible with the Anthropic and Google serializers, while the Responses path remains separate.
  • Regression coverage and release metadata — focused tests cover empty and image content plus a tool-only assistant request, and the patch changeset is present.

Pullfrog  | View workflow run | Using GPT Luna𝕏

@grikomsn
grikomsn merged commit 60723d4 into main Aug 20, 2026
5 checks passed
@grikomsn
grikomsn deleted the codex/fix-deepseek-tool-content branch August 20, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: DeepSeek V4 Flash rejects tool-only message serialized with content: null

1 participant