Skip to content

fix: retry generic transient upstream errors - #14

Merged
grikomsn merged 2 commits into
mainfrom
codex/fix-issues-12-13
Aug 22, 2026
Merged

fix: retry generic transient upstream errors#14
grikomsn merged 2 commits into
mainfrom
codex/fix-issues-12-13

Conversation

@grikomsn

Copy link
Copy Markdown
Owner

Summary

  • retry the gateway's explicit generic 500 Internal server error response with the existing bounded backoff
  • retain non-transient 500 failures as terminal
  • add regression coverage and a patch changeset

Issue status

Verification

  • npm test (71 passing)
  • npm run package
  • VS Code Extension Development Host: provider registered, native Thinking Effort control present, and a DeepSeek V4 Flash tool-result round-trip completed successfully.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The generic 500 retry path still does not match the error reported by the issue, so this PR should not merge until the call-site contract is covered.

Reviewed changes This review covers the retry classification update and its release and regression-test coverage.

  • Generic transient 500 classification Extends the retry predicate to recognize the gateway's exact Internal server error text for HTTP 500 responses.
  • Release and regression coverage Adds a patch changeset and a unit assertion for the new classification.

Pullfrog  | Fix all ➔Fix 👍s ➔View workflow run | Using GPT Luna𝕏

Comment thread src/provider/retry.ts Outdated

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes This incremental review covers the follow-up that aligns generic 500 classification with the actual formatted provider error.

  • Matched formatted upstream errors Updated the transient 500 predicate to recognize the responseError message shape while retaining terminal handling for unrelated 500 details.
  • Added regression coverage Pinned the exact issue-shaped error message so the prior call-site mismatch would fail the test.

Pullfrog  | View workflow run | Using GPT Luna𝕏

@grikomsn grikomsn self-assigned this Aug 22, 2026
@grikomsn
grikomsn merged commit 2a74245 into main Aug 22, 2026
5 checks passed
@grikomsn
grikomsn deleted the codex/fix-issues-12-13 branch August 22, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant