Repository navigation
Reuse verified snapshot source for bounded context followups - #228
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v17 PR305 run repeatedly retrieved source files that were already captured in full, but omitted from specialist inputs. Its 16 KB retrieval IPC envelope truncated those files, consumed all eight retrieval slots, and prevented follow-up assessments.
Reuse a unique complete HEAD snapshot row for manifest-bound implementation/test targets after verifying the original snapshot identity, UTF-8 content hash, Git blob identity, full byte size, and evidence ID. Preserve the original
head_fileanduntrusted_pr_contentclassifications and recordSNAPSHOT_REUSEexplicitly. Oversized reused-source requests fail the existing size preflight before consuming a follow-up slot, leaving later fitting requests eligible. Follow-up assessments still consume the existing model/input/follow-up budgets; captured evidence alone never resolves a review gap. Legacy inline retrieval and unavailable/truncated evidence retain their existing behavior.Pin the read-only pilot caller to the immutable qualified code commit so the next trial exercises this repair. Also update the three current-evidence documents with run 37686481212 and PR227/post-merge verification, preserving the historical requirement trace and incomplete quality status.
Validation: 311 focused engine, target-manifest, follow-up-contract, and real-case tests passed; Ruff and diff checks passed. Regression coverage exercises source reuse without a retrieval reservation, immutable binding tampering, invalid UTF-8, Unicode snapshot IDs, and oversized-first/fitting-second admission under a one-follow-up cap. Independent source review is CLEAR. Provider-backed behavior on this new source has not yet been measured; publication remains disabled.