Repository navigation
fix: bind artifact downloads to authenticated GitHub API redirects - #233
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub served real review artifacts from different storage hosts, so the protected publisher rejected valid downloads despite successful analysis. The v3 protected policy admits only the ephemeral HTTPS Location returned by the authenticated GitHub artifact API for an already-bound artifact ID. Both fetch paths use the same validator and retain the size, digest, manifest and workflow/run/head checks. Storage receives no GitHub bearer token, and a second redirect is refused. Existing v1/v2 static-host behavior remains unchanged.
The three caller files are pinned together to the reviewed core commit. No inference model, review rubric, budget or disposition behavior changes.
Validation: 101 focused publication/runtime tests and 68 caller/profile tests passed; Ruff, JSON/YAML parsing and diff checks passed. Independent review CLEAR for the core and atomic pins. Real target publication remains to be verified after deployment.