Skip to content

Fix durable research failing before it produces a report - #683

Merged
magnus919 merged 5 commits into
mainfrom
fix/smoke-durable-research
Oct 17, 2026
Merged

magnus919 merged 5 commits into
mainfrom
fix/smoke-durable-research

Conversation

@magnus919

@magnus919 magnus919 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

What changes

Durable research could finish searching and collecting sources, then fail without producing a report. Its construction request allowed only 2,048 output tokens even when the deployment allowed more. In the reproduced failure, the model used that entire allowance for reasoning and returned no answer.

New research runs now use the configured completion allowance, capped at 8,192 tokens. They also select relevant passages before constructing the answer, so the model does not have to process every captured page in full. Captured sources remain available in full, and citations are checked against the passages actually shown to the model.

Older saved runs keep their original request format so recovery can reuse their recorded responses. This change does not retry calls whose outcome is unknown.

Validation

  • Construction, model review and planning tests passed locally.
  • Ten isolated Valkey recovery tests passed, including old and new policies and recovery without repeated model calls.
  • Added tests for source selection across eight documents, exact citation locations, omitted passages and oversized lines.
  • Independent code review found no blocking issue. Repository hooks passed.
  • CI must also pass the HTTP integration tests with isolated Valkey, PostgreSQL and controlled providers before merge.

A separate real-model confirmation over the eight already captured sources completed construction, review and all three reports in 132.8 seconds using two calls. No searches were repeated. An earlier attempt timed out at 90.1 seconds and is retained as a failed observation; the successful run does not establish consistent latency. The deployment remains unchanged.

@factory-droid

factory-droid Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Droid encountered an error —— View job

Droid Exec exited with code 1:
Tool "Edit" skipped (Nous-GPT-6-Luna uses ApplyPatch instead).
Tool "Create" skipped (Nous-GPT-6-Luna uses ApplyPatch instead).

Security Review

1 similar comment
@factory-droid

factory-droid Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Droid encountered an error —— View job

Droid Exec exited with code 1:
Tool "Edit" skipped (Nous-GPT-6-Luna uses ApplyPatch instead).
Tool "Create" skipped (Nous-GPT-6-Luna uses ApplyPatch instead).

Security Review

@magnus919
magnus919 marked this pull request as draft October 16, 2026 20:07
@magnus919
magnus919 marked this pull request as ready for review October 16, 2026 20:07
@magnus919
magnus919 marked this pull request as draft October 17, 2026 00:02
@magnus919
magnus919 marked this pull request as ready for review October 17, 2026 00:02
@factory-droid

factory-droid Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Droid finished @magnus919's task —— View job


Security Review

The candidate set contains no inline findings to validate. The full diff contains bounded evidence selection, preserved line references, citation checks against presented excerpts, and policy-version-specific budgets, with legacy replay behavior unchanged.

0 inline comments posted

@magnus919
magnus919 merged commit a4065b3 into main Oct 17, 2026
35 of 37 checks passed
@magnus919
magnus919 deleted the fix/smoke-durable-research branch October 17, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant