Skip to content

Let new research jobs finish within one five-minute deadline - #691

Merged
magnus919 merged 2 commits into
mainfrom
fix/shared-research-deadline
Oct 17, 2026
Merged

magnus919 merged 2 commits into
mainfrom
fix/shared-research-deadline

Conversation

@magnus919

@magnus919 magnus919 commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Slow but successful model responses were being cut off before research could finish. A measured draft took 153 seconds, and planning, capture, and review put the complete job beyond the previous three-minute limit.

New research jobs now receive a shared five-minute execution deadline, recorded as admission policy durable-live/5. Model stages can use the remaining time without hitting shorter internal timers. Existing jobs retain their original policy and limits. Search counts, model-call counts, token limits, and the rule against replaying uncertain calls are unchanged.

ADR-0074 and the durable research guide explain the limit and rollback requirements. Focused verification passed 82 tests, including the measured timing sequence, legacy policy behavior, deadline cancellation, and protection against replaying uncertain model calls. HTTP acceptance also checks the advertised limit and stored admission policy.

@factory-droid

factory-droid Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Droid finished @magnus919's task —— View job


The change gives version-4 drafting and model review access to the existing 180-second execution deadline while preserving shorter limits for earlier policies. The outer deadline and durable no-replay behavior remain in place; no high-confidence actionable issues were found.

0 inline comments posted

@magnus919 magnus919 changed the title Use the full research time limit for drafting and review Let new research jobs finish within one five-minute deadline Oct 17, 2026
@magnus919

Copy link
Copy Markdown
Contributor Author

Independent review of commit 5efeef0b4f3e6a05eeedccc072d24d92a708aaa2: no blocking findings.

The stored admission policy controls the shared deadline. Version 5 receives 300 seconds through the transport, drafting and review stages. Version 4 retains its original 180-second overall limit, 120-second drafting limit and 90-second review limit. Fixture admissions remain version 4.

The review checked policy propagation, historical behavior, cancellation and protection against replaying uncertain calls. Tests cover the measured 213-second sequence, expiration beyond 300 seconds, and the earlier model-stage limits. ADR-0074 documents the change and requires draining active version-5 jobs before rollback to an older worker.

@magnus919
magnus919 merged commit abacf8d into main Oct 17, 2026
25 checks passed
@magnus919
magnus919 deleted the fix/shared-research-deadline branch October 17, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant