Repository navigation
Conversation
Signed-off-by: Magnus Hedemark <magnus919@pm.me>
Signed-off-by: Magnus Hedemark <magnus919@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Existing deployments can run canonical GroktoCrawl while retaining names such as
groktocrawl-x-candidate-candidate-agent-1. The candidate runbook still describes this as a separate X experiment, which makes those names misleading after the architecture's adoption in PR #665 and v1.0.0.Clarify the retained topology, trace Compose/MCP/portal/HAProxy naming contracts, link canonical image provenance, and distinguish an application update from an operator-led topology migration. Add the same warning to the mainline migration runbook. Compose values remain unchanged.
Related Issue
Requested directly by Magnus after verifying canonical source running under retained X deployment names. Related adoption context: #665. No additional issue created.
Type of Change
Test Plan
python3 scripts/check-docs-surface.pypassed.python3 -m pytest tests/unit/test_mainline_migration_compose.py -o addopts='' -q --noconftest: 6 passed.git diff --checkpassed.Checklist
Notes for Reviewers
The same naming convention is present in maintained compatibility templates, but the observed production launch uses an explicit -p argument and private generated Compose inputs outside Git. No checked-in generator for those private files was found. Standard docker-compose.yml already has no X naming defaults. Template edits alone cannot rename that live deployment. The identifiers remain connected resource and routing contracts. A cosmetic rename can select different volumes/networks or break MCP/proxy routing; any future rename needs a separately rehearsed data/route migration and rollback plan. Historical experiment ADRs and fixtures remain historical evidence.
This PR changes no project names, service names, networks, volumes, images, ports, runtime routing, dependencies, or live deployment. No production tests or container operations were performed. Draft status avoids invoking the repository's paid AI review job; no manual scan/build/review runs requested.
Prepared by Codex (AI agent on behalf of Magnus Hedemark).
Scope limit: this draft documents naming/provenance and migration prerequisites; it does not complete a runtime naming migration. A follow-up design must choose retained candidate service topology with new names versus migration to the existing standard topology, explicitly preserving data/network/route mappings.