Fix/message create event#13
Conversation
|
@grottohub I see that you merged a lot of things to main and it will not be so easy to merge with my changes.
|
|
great! ill take a look through this today, but as its a bit sizable and ill need to think about merge strategy, might not have full feedback until tomorrow |
grottohub
left a comment
grottohub
left a comment
There was a problem hiding this comment.
just a few questions / tweaks. overall awesome work! personally im fine with merging this in once the .toml file conflicts get resolved - its ok if main is a bit unstable while we make such a big change in how we're doing decoders, then ill go in and make any necessary tweaks to the types that i need to.
| logging = "~> 1.0" | ||
| prng = "~> 3.0" | ||
| carpenter = "~> 0.2" | ||
| glyph_codegen = "~> 0.3" |
There was a problem hiding this comment.
this should go in [dev-dependencies]
|
|
||
| target = "erlang" | ||
| gleam = ">= 1.0.0" | ||
| gleam = ">= 0.32.0" |
There was a problem hiding this comment.
is there a reason we've lowered the minimum version?
| debug(event) | ||
| debug(message) |
|
@grottohub I will fix these issues today or tomorrow |
|
@grottohub I fixed these conflicts. In this week I will not have time for gleam/glyph 😞 I'm really want to finish glyph_codegen because right now the conversion between field type to I want to create generic codegen for json that accept any field type and share with the gleam community. |
2 participants
No description provided.