add --node flag for filtering on pods from specific node - #28
Open
skoef wants to merge 1 commit into
Open
Conversation
Author
|
@maxlevinps Please take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While investigating a node with high CPU usage I figured I see what murre would show me. But knowing which node that had high CPU it wasn't super obvious which pods with high CPU usage were actually on that node. So I added a
--nodeflag to murre allowing you to filter on a specific node, as well as you could already filter on namespace and pods.While filtering on a node, murre still fetches metrics from all other nodes, but this is how murre was designed to operate. When you filter on a pod, all data for all other pods is collected as well, but not shown.