Drop the Dart binding's unused serde_json dependency - #117
Open
ifaouibadi wants to merge 1 commit into
Open
ifaouibadi wants to merge 1 commit into
ifaouibadi wants to merge 1 commit into
Conversation
The 2.13.0 codegen sync added serde_json to bindings/dart/rust/Cargo.toml on the assumption the generated SSE codec referenced it directly, but the committed frb_generated.rs never does — the qualified-path fix for the Value/serde_json::Value name collision made the dependency unnecessary before the commit landed. Confirmed by a clean regen: dropping it produces zero diff in the generated glue, and cargo build/clippy/fmt and dart analyze/test all stay green.
Contributor
|
Thanks for the pull request — it is in the queue and a maintainer will review it. This repository is maintained on a weekly cadence. Anything opened from outside gets What happens next:
If this is a security fix for an unreported vulnerability, please close it and use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developaddedserde_jsontobindings/dart/rust/Cargo.tomlon the assumption the generated SSE codec referenced it directly; the committedfrb_generated.rsnever does, so the dependency was dead weight.Cargo.toml: zero diff in the generated Dart/Rust glue, soserde_jsonwas never load-bearing.Test plan
cargo fmt --all -- --checkcargo clippy --locked --all-targets -- -D warningscargo build --release --lockedflutter_rust_bridge_codegen generate --config-file flutter_rust_bridge.yamlthengit status --porcelainclean (no drift)dart analyze --fatal-infosdart test(92/92 passing)