Skip to content

Drop the Dart binding's unused serde_json dependency - #117

Open
ifaouibadi wants to merge 1 commit into
developfrom
agent/growae-bindings-engineer-react/dart-remove-unused-serde-json
Open

ifaouibadi wants to merge 1 commit into
developfrom
agent/growae-bindings-engineer-react/dart-remove-unused-serde-json

Conversation

@ifaouibadi

Copy link
Copy Markdown
Contributor

Summary

  • The codegen-sync fix on develop added serde_json to bindings/dart/rust/Cargo.toml on the assumption the generated SSE codec referenced it directly; the committed frb_generated.rs never does, so the dependency was dead weight.
  • Confirmed by regenerating from a clean Cargo.toml: zero diff in the generated Dart/Rust glue, so serde_json was never load-bearing.

Test plan

  • cargo fmt --all -- --check
  • cargo clippy --locked --all-targets -- -D warnings
  • cargo build --release --locked
  • flutter_rust_bridge_codegen generate --config-file flutter_rust_bridge.yaml then git status --porcelain clean (no drift)
  • dart analyze --fatal-infos
  • dart test (92/92 passing)

The 2.13.0 codegen sync added serde_json to bindings/dart/rust/Cargo.toml
on the assumption the generated SSE codec referenced it directly, but the
committed frb_generated.rs never does — the qualified-path fix for the
Value/serde_json::Value name collision made the dependency unnecessary
before the commit landed. Confirmed by a clean regen: dropping it produces
zero diff in the generated glue, and cargo build/clippy/fmt and dart
analyze/test all stay green.
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Thanks for the pull request — it is in the queue and a maintainer will review it.

This repository is maintained on a weekly cadence. Anything opened from outside gets
a human reply within 2 business days; this comment is automation confirming your
pull request landed, and it is not that reply.

What happens next:

  • CI runs on the pull request. Check, Build and Test need to be green before
    review — you can push fixes straight to the same branch.
  • A maintainer reviews it against CONTRIBUTING.md.
  • A change to a package's public API, or a new dependency, needs a maintainer
    decision before it can merge. That is where the call gets made rather than a
    delay, and we will tell you either way instead of leaving it open.

If this is a security fix for an unreported vulnerability, please close it and use
the private channel first
SECURITY.md.
A public pull request describes the flaw to everyone before the fix is released.

@github-actions github-actions Bot added the triage Acknowledged, not yet routed label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Acknowledged, not yet routed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant