crates, bindings: correct stated MSRV to 1.85 - #120
Open
ifaouibadi wants to merge 1 commit into
Open
ifaouibadi wants to merge 1 commit into
ifaouibadi wants to merge 1 commit into
Conversation
Resolved-graph audit (cargo metadata --locked) across crates/ and each binding's own lockfile (dart/rust, python) shows curve25519-dalek 5.0.0 and the blake2/sha2 0.11 chain as the true maximum declared rust-version in every one of them: 1.85, not the previously stated 1.82. No toolchain change; crates/rust-toolchain.toml and the wasm binding's stay pinned at 1.97.1, already above the corrected floor.
Contributor
|
Thanks for the pull request — it is in the queue and a maintainer will review it. This repository is maintained on a weekly cadence. Anything opened from outside gets What happens next:
If this is a security fix for an unreported vulnerability, please close it and use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/Cargo.toml[workspace.package] rust-versionstated1.82; a fullcargo metadata --lockedaudit of the resolved graph shows the true maximum declaredrust-versionin the tree is1.85(curve25519-dalek 5.0.0, and the blake2/sha2 0.11 chain: digest, ed25519-dalek, sha2, blake2, zeroize, hybrid-array, ctutils, rand_core 0.10). Corrected to1.85.ae-coreand carry their ownCargo.lock—bindings/dart/rustandbindings/python— each independently declared the same stale1.82and resolve to the same true maximum1.85(verified per-tree with their owncargo metadata --locked, not inherited). Corrected both to match.bindings/wasm-js/core-component/Cargo.tomldeclares norust-versionfield at all, so there is no stale value to fix; its resolved graph also tops out at1.85if the field is ever added. Left untouched — out of scope for a documentation-correction PR.crates/rust-toolchain.tomlandbindings/wasm-js/core-component/rust-toolchain.tomlstay pinned at1.97.1, already above the corrected floor.Test plan
cargo check --locked --workspaceincrates/— clean, no lockfile driftcargo check --lockedinbindings/dart/rust— clean, no lockfile driftcargo check --lockedinbindings/python— clean, no lockfile driftgit statusconfirms only the threeCargo.tomlfiles changed; noCargo.locktouched anywhere