Conversation
| run: | | ||
| # Linting | ||
| yarn lint | ||
| # Temporarily disabled due to code drift while this script wasn't running |
There was a problem hiding this comment.
This workflow has been broken for ages so it hasn't been linting the files. I'm fixing lint issues in a separate branch and then we can re-enable this.
tzjames
left a comment
tzjames
left a comment
There was a problem hiding this comment.
Looks good other than the script runner for prod.
package.json
Outdated
| "start": "pnpm --filter @growthbook/proxy start", | ||
| "start:with-tracing": "pnpm --filter @growthbook/proxy start:with-tracing", |
There was a problem hiding this comment.
We seemed to have memory leaks using pnpm on prod. It is kind of not meant for that. We ended up going with pm2 for growthbook, I'd suggest we do that here too.
There was a problem hiding this comment.
Good suggestion. I borrowed the setup from the main repo, but didn't use the ecosystem.config in the dockerfile. Lmk if you think anything there should change.
I did test both the pnpm start and docker run entrypoints which worked fine
3 participants
Description
Migrates all uses of
yarntopnpmto bring us to parity with our other reposspdydoesn't work with v24. It looks like there's a drop-in replacement withhttp2-express-bridgebut I'm leaving that for a separate PRTesting
pnpmbuild succeeds