Skip to content

feat: add case-insensitive operators ini, nini, alli to condition evaluator #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vazarkevych merged 8 commits into from
Apr 7, 2026
Merged

feat: add case-insensitive operators ini, nini, alli to condition evaluator #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d280938
feat: update test-cases.json with new insensitive tests for ini and a…
Feb 19, 2026
2b0f862
feat: add new enum Operator constants: INI, NINI, ALLI
Feb 19, 2026
d4c32fa
feat: add caseFold function
Feb 19, 2026
74c190a
feat: add isInAll function, refactor isInFunction for insensitive cases
Feb 19, 2026
a8c78be
feat: update evalOperatorCondition function with new insensitive oper…
Feb 19, 2026
f775dcd
feat: update evalConditionValue function with insensitive logic; add …
Feb 19, 2026
e9539fe
refactor: clean up code
Feb 19, 2026
eab8480
refactor: remove redundant comments
Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
207 changes: 100 additions & 107 deletions lib/src/main/java/growthbook/sdk/java/evaluators/ConditionEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@
import com.google.gson.JsonObject;
import com.google.gson.JsonPrimitive;
import com.google.gson.JsonSyntaxException;
import com.google.gson.reflect.TypeToken;
import growthbook.sdk.java.util.GrowthBookJsonUtils;
import growthbook.sdk.java.model.Operator;
import growthbook.sdk.java.util.StringUtils;
import growthbook.sdk.java.model.DataType;
import lombok.extern.slf4j.Slf4j;

import javax.annotation.Nullable;
import java.lang.reflect.Type;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Map;
Expand Down Expand Up @@ -233,79 +231,23 @@ Boolean evalOperatorCondition(String operatorString, @Nullable JsonElement actua
switch (operator) {
case IN:
if (actual == null) return false;
if (!expected.isJsonArray()) return false;
return isIn(actual, expected.getAsJsonArray(), false);

if (DataType.ARRAY == attributeDataType) {
if (!expected.isJsonArray()) return false;

JsonArray value = actual.getAsJsonArray();
JsonArray expectedArr = expected.getAsJsonArray();

return isIn(value, expectedArr);
}

if (DataType.STRING == attributeDataType) {
String value = actual.getAsString();
Type listType = new TypeToken<ArrayList<String>>() {
}.getType();
ArrayList<String> conditionsList = jsonUtils.gson.fromJson(expected, listType);
return conditionsList.contains(value);
}

if (DataType.NUMBER == attributeDataType) {
Float value = actual.getAsFloat();
Type listType = new TypeToken<ArrayList<Float>>() {
}.getType();
ArrayList<Float> conditionsList = jsonUtils.gson.fromJson(expected, listType);
return conditionsList.contains(value);
}

if (DataType.BOOLEAN == attributeDataType) {
Boolean value = actual.getAsBoolean();
Type listType = new TypeToken<ArrayList<Boolean>>() {
}.getType();
ArrayList<Boolean> conditionsList = jsonUtils.gson.fromJson(expected, listType);
return conditionsList.contains(value);
}
break;

case INI:
if (actual == null) return false;
if (!expected.isJsonArray()) return false;
return isIn(actual, expected.getAsJsonArray(), true);

case NIN:
if (actual == null) return false;
if (!expected.isJsonArray()) return false;
return !isIn(actual, expected.getAsJsonArray(), false);

if (DataType.ARRAY == attributeDataType) {
if (!expected.isJsonArray()) return false;

JsonArray value = actual.getAsJsonArray();
JsonArray expectedArr = expected.getAsJsonArray();

return !isIn(value, expectedArr);
}

if (DataType.STRING == attributeDataType) {
String value = actual.getAsString();
Type listType = new TypeToken<ArrayList<String>>() {
}.getType();
ArrayList<String> conditionsList = jsonUtils.gson.fromJson(expected, listType);
return !conditionsList.contains(value);
}

if (DataType.NUMBER == attributeDataType) {
Float value = actual.getAsFloat();
Type listType = new TypeToken<ArrayList<Float>>() {
}.getType();
ArrayList<Float> conditionsList = jsonUtils.gson.fromJson(expected, listType);
return !conditionsList.contains(value);
}

if (DataType.BOOLEAN == attributeDataType) {
Boolean value = actual.getAsBoolean();
Type listType = new TypeToken<ArrayList<Boolean>>() {
}.getType();
ArrayList<Boolean> conditionsList = jsonUtils.gson.fromJson(expected, listType);
return !conditionsList.contains(value);
}
break;

case NINI:
if (actual == null) return false;
if (!expected.isJsonArray()) return false;
return !isIn(actual, expected.getAsJsonArray(), true);

case GT:
if (actual == null || DataType.NULL.equals(attributeDataType)) {
Expand Down Expand Up @@ -394,20 +336,13 @@ Boolean evalOperatorCondition(String operatorString, @Nullable JsonElement actua

case ALL:
if (actual == null || !actual.isJsonArray()) return false;
JsonArray actualArrayForAll = (JsonArray) actual;
JsonArray expectedArrayForAll = (JsonArray) expected;

for (int i = 0; i < expectedArrayForAll.size(); i++) {
boolean passed = false;
for (int j = 0; j < actualArrayForAll.size(); j++) {
if (evalConditionValue(expectedArrayForAll.get(i), actualArrayForAll.get(j), savedGroups)) {
passed = true;
break;
}
}
if (!passed) return false;
}
return true;
if (!expected.isJsonArray()) return false;
return isInAll(actual.getAsJsonArray(), expected.getAsJsonArray(), savedGroups, false);

case ALLI:
if (actual == null || !actual.isJsonArray()) return false;
if (!expected.isJsonArray()) return false;
return isInAll(actual.getAsJsonArray(), expected.getAsJsonArray(), savedGroups, true);

case NOT:
return !evalConditionValue(expected, actual, savedGroups);
Expand Down Expand Up @@ -472,17 +407,17 @@ Boolean evalOperatorCondition(String operatorString, @Nullable JsonElement actua
if (actual != null && expected != null) {
JsonElement jsonElement = savedGroups != null ? savedGroups.get(expected.getAsString()) : null;
if (jsonElement != null) {
return isIn(actual, jsonElement.getAsJsonArray());
return isIn(actual, jsonElement.getAsJsonArray(), false);
}
return isIn(actual, new JsonArray());
return isIn(actual, new JsonArray(), false);
}
case NOT_IN_GROUP:
if (actual != null && expected != null) {
JsonElement jsonElement = savedGroups != null ? savedGroups.get(expected.getAsString()) : null;
if (jsonElement != null) {
return !isIn(actual, jsonElement.getAsJsonArray());
return !isIn(actual, jsonElement.getAsJsonArray(), false);
}
return !isIn(actual, new JsonArray());
return !isIn(actual, new JsonArray(), false);
}
default:
return false;
Expand Down Expand Up @@ -533,12 +468,19 @@ Boolean arePrimitivesEqual(JsonPrimitive a, JsonPrimitive b, DataType dataType)
* @param attributeValue Object or primitive
* @return true if equal
*/
Boolean evalConditionValue(JsonElement conditionValue, @Nullable JsonElement attributeValue, @Nullable JsonObject savedGroups) {
Boolean evalConditionValue(JsonElement conditionValue, @Nullable JsonElement attributeValue, @Nullable JsonObject savedGroups, boolean inSensitive) {

if (conditionValue == null) {
return attributeValue == null;
}
DataType conditionValueElementType = GrowthBookJsonUtils.getElementType(conditionValue);
DataType attributeValueElementType = GrowthBookJsonUtils.getElementType(attributeValue);

if (inSensitive && attributeValue != null
&& attributeValueElementType == DataType.STRING
&& conditionValueElementType == DataType.STRING) {
return conditionValue.getAsString().equalsIgnoreCase(attributeValue.getAsString());
}

switch (conditionValueElementType) {
case STRING:
Expand Down Expand Up @@ -578,6 +520,10 @@ Boolean evalConditionValue(JsonElement conditionValue, @Nullable JsonElement att
}
}

Boolean evalConditionValue(JsonElement conditionValue, @Nullable JsonElement attributeValue, @Nullable JsonObject savedGroups) {
return evalConditionValue(conditionValue, attributeValue, savedGroups, false);
}

Boolean elemMatch(JsonElement actual, JsonElement expected, @Nullable JsonObject savedGroups) {
if (!actual.isJsonArray()) {
return false;
Expand Down Expand Up @@ -641,34 +587,68 @@ Boolean evalAnd(JsonElement attributes, JsonArray conditions, @Nullable JsonObje
return true;
}

private Boolean isIn(JsonElement actual, JsonArray expected) {
Type listType = new TypeToken<ArrayList<Object>>() {
}.getType();
ArrayList<JsonElement> expectedAsList = jsonUtils.gson.fromJson(expected, listType);
private Boolean isIn(JsonElement actual, JsonArray expected, boolean inSensitive) {
if (actual == null) return false;

if (!actual.isJsonArray()) return expected.contains(actual);
if (!actual.isJsonArray()) {
// actual is a primitive — check if expected contains it
if (inSensitive) {
for (JsonElement exp : expected) {
if (caseFold(actual).equals(caseFold(exp))) {
return true;
}
}
return false;
}
return expected.contains(actual);
}

// actual is an array — check if any actual element matches any expected element
JsonArray actualArr = actual.getAsJsonArray();

if (actualArr.isEmpty()) return false;

DataType attributeDataType = GrowthBookJsonUtils.getElementType(actualArr.get(0));
ArrayList<Object> actualAsList = jsonUtils.gson.fromJson(actualArr, listType);

return actualAsList.stream()
.anyMatch(o -> {
if (
attributeDataType == DataType.STRING ||
attributeDataType == DataType.NUMBER ||
attributeDataType == DataType.BOOLEAN
) {
return expectedAsList.contains(o);
for (JsonElement actualItem : actualArr) {
for (JsonElement expectedItem : expected) {
if (inSensitive) {
if (caseFold(actualItem).equals(caseFold(expectedItem))) {
return true;
}
} else {
if (Objects.equals(actualItem, expectedItem)) {
return true;
}
}
}
}
return false;
}

return false;
});
/**
* Checks that for every element in expected, there is at least one matching element in actual.
* Uses evalConditionValue for comparison, which supports operator objects.
*
* @param actual the attribute value (must be an array)
* @param expected the condition array — every item must match at least one in actual
* @param savedGroups saved groups for group-based conditions
* @param inSensitive if true, string comparisons are case-insensitive
* @return true if all expected items are matched
*/
private Boolean isInAll(JsonArray actual, JsonArray expected, @Nullable JsonObject savedGroups, boolean inSensitive) {
for (int i = 0; i < expected.size(); i++) {
boolean passed = false;
for (int j = 0; j < actual.size(); j++) {
if (evalConditionValue(expected.get(i), actual.get(j), savedGroups, inSensitive)) {
passed = true;
break;
}
}
if (!passed) return false;
}
return true;
}


private <T> boolean isMatchingPrimitive(
JsonElement conditionValue,
JsonElement attributeValue,
Expand Down Expand Up @@ -699,4 +679,17 @@ private static Boolean evalRegex(@Nullable JsonElement actual,
return false;
}
}

/**
* Folds a JsonElement to lowercase if it's a string and inSensitive is true.
* Used where you need a folded value rather than a comparison.
*/
private JsonElement caseFold(@Nullable JsonElement value) {
if (value != null
&& value.isJsonPrimitive()
&& value.getAsJsonPrimitive().isString()) {
return new JsonPrimitive(value.getAsString().toLowerCase());
}
return value;
}
}
12 changes: 12 additions & 0 deletions lib/src/main/java/growthbook/sdk/java/model/Operator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,18 @@ public enum Operator {
* $in
*/
IN("$in"),
/**
* $ini
*/
INI("$ini"),
/**
* $nin
*/
NIN("$nin"),
/**
* $nin
*/
NINI("$nini"),
/**
* $gt
*/
Expand Down Expand Up @@ -66,6 +74,10 @@ public enum Operator {
* $all
*/
ALL("$all"),
/**
* $all
*/
ALLI("$alli"),
/**
* $not
*/
Expand Down
Loading
Loading