Skip to content

feat: performance improvement (Do not merge maps if the globalForcedVariations or userForcedVariations are empty… #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaurav-rana wants to merge 5 commits into from
Closed

feat: performance improvement (Do not merge maps if the globalForcedVariations or userForcedVariations are empty… #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a37969
Do not merge maps if the userFeatures or globalFeatures are empty or …
gaurav-rana Mar 12, 2026
ccf825b
optimize merge maps
gaurav-rana Mar 12, 2026
b7ed65e
remove redundant line
gaurav-rana Mar 12, 2026
709358b
return a new map
gaurav-rana Mar 12, 2026
606189d
return a new map
gaurav-rana Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/src/main/java/growthbook/sdk/java/evaluators/ExperimentEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,13 +419,11 @@ private <ValueType> boolean isStickyBucketingEnabledForExperiment(EvaluationCont

private Map<String, Integer> getForcedVariations(EvaluationContext evaluationContext) {
Map<String, Integer> globalForcedVariations = evaluationContext.getGlobal() != null
? evaluationContext.getGlobal().getForcedVariations()
: Collections.emptyMap();
? evaluationContext.getGlobal().getForcedVariations() : null;

Map<String, Integer> userForcedVariations = evaluationContext.getUser() != null
? evaluationContext.getUser().getForcedVariationsMap()
: Collections.emptyMap();
? evaluationContext.getUser().getForcedVariationsMap() : null;

return GrowthBookUtils.mergeMaps(Arrays.asList(globalForcedVariations, userForcedVariations));
return GrowthBookUtils.mergeMaps(globalForcedVariations, userForcedVariations);
}
}
6 changes: 3 additions & 3 deletions lib/src/main/java/growthbook/sdk/java/evaluators/FeatureEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,12 +466,12 @@ private <ValueType> FeatureResult<ValueType> cacheResult(String key, FeatureResu
private Map<String, Object> getForcedFeatureValues(EvaluationContext evaluationContext) {
Map<String, Object> globalFeatures = evaluationContext.getGlobal() != null
? evaluationContext.getGlobal().getForcedFeatureValues()
: Collections.emptyMap();
: null;

Map<String, Object> userFeatures = evaluationContext.getUser() != null
? evaluationContext.getUser().getForcedFeatureValues()
: Collections.emptyMap();
: null;

return GrowthBookUtils.mergeMaps(Arrays.asList(globalFeatures, userFeatures));
return GrowthBookUtils.mergeMaps(globalFeatures, userFeatures);
}
}
20 changes: 6 additions & 14 deletions lib/src/main/java/growthbook/sdk/java/util/GrowthBookUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
import java.util.Map;
import java.util.Objects;
import java.util.Set;
import java.util.stream.Collectors;

/**
* <b>INTERNAL</b>: Implementation of for internal utility methods to support {@link growthbook.sdk.java.GrowthBook}
*/
Expand Down Expand Up @@ -919,17 +917,11 @@ private static int findVariationIndex(List<VariationMeta> meta, String variation
return -1;
}

public static <K, V> Map<K, V> mergeMaps(List<Map<K, V>> maps) {
return maps.stream()
.filter(Objects::nonNull)
.flatMap(map -> map.entrySet()
.stream())
.collect(Collectors.toMap(
Map.Entry::getKey,
Map.Entry::getValue,
(v1, v2) -> v2
)
);

public static <K, V> Map<K, V> mergeMaps(@Nullable Map<K, V> base, @Nullable Map<K, V> overrides) {
if (base == null || base.isEmpty()) return overrides != null ? new HashMap<>(overrides) : Collections.emptyMap();
Copy link
Copy Markdown
Collaborator

@vazarkevych vazarkevych Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's return new HashMap<>() instead of Collections.emptyMap() for consistency — so the method always returns a mutable map and we prevent a potential UnsupportedOperationException if someone mutates the result in the future.

if (overrides == null || overrides.isEmpty()) return new HashMap<>(base);
Map<K, V> merged = new HashMap<>(base);
merged.putAll(overrides);
return merged;
}
}
Loading