Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on top of the improvements in #196. The goal is to reduce allocations in the feature/experiment evaluation path highlighted in PR #196, especially around forced override lookups.
The PR #196 already removes a stream/list-based map merge from a hot evaluation path. This follow-up keeps the change(removal of stream/list-based map merge from a hot evaluation path) intact and adds below:
GrowthBookUtils.mergeMaps(...)and preserve API compatibility.UserContextdefaults so getters stop allocating on readPerformance Results
Measured with:
Test Harness Results