Avoid force-creating activities

[ArtemSerostanov]

The problem

Force-creating activities via new Activity(...) breaks fundamental Activity logic. You are replacing Activity.Current, but the other code does not expect this, because nobody listens to your activity source and nobody expects Activity.Current to suddenly change.

For example, if I roll a custom SubchannelPicker implementation and start creating activities there, these activities will be broken when exported to tracing collector. This happens because you have forcibly replaced Activity.Current, so my custom activity will have your activity as a parent. But nobody listens to your activity source, so your Activity is not exported, which means my custom activity will have an unknown parent activity id.

The solution

Do not create an activity if nobody listens to your activity source

[linux-foundation-easycla]

• ❌ - login: @searoz / name: Serostanov Artem . The commit (09b1a76) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.