Fix System.CommandLine 2.0.0 Uri parsing in GrpcClient benchmark app#2695
Merged
JamesNK merged 1 commit intogrpc:masterfrom Mar 9, 2026
Merged
Conversation
|
|
jeffhandley
approved these changes
Mar 7, 2026
|
@JamesNK Can you help us get this change through the CLA process? It's currently blocking our benchmarks runs. |
JamesNK
requested changes
Mar 9, 2026
System.CommandLine 2.0.0 has no built-in converter for System.Uri, causing all 48 Grpc benchmark tasks to crash with InvalidOperationException when parsing the --url option. Add a CustomParser to the Option<Uri> definition as the documented workaround (see dotnet/command-line-api#2574). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ilonatommy
force-pushed
the
fix/system-commandline-uri-parsing
branch
from
2846252 to
1bc808c
Compare
JamesNK
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.CommandLine 2.0.0has no built-in converter forSystem.Uri, causing all crashes withInvalidOperationExceptionwhen parsing the--urloption.Changes
CustomParserto the Option definition as the documented workaround (see addUritoArgumentConverter.StringConvertersdotnet/command-line-api#2574) until the issue gets fixed at source.Grpc.Net.Client.Teststo verify the parsing behavior.Fixes #2694