Fix BigInt tests to work with React 18#30
Merged
Merged
Conversation
BigInt rendering is only supported in React 19+. React 18's Children.toArray strips BigInts before flattenChildren sees them. Updated tests to: - React 19+: verify BigInts are preserved in output - React 18: verify BigInts are filtered (expected behavior) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
grrowl
force-pushed
the
fix/bigint-tests
branch
from
86b0536 to
2701af6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI failures from #29 where BigInt tests failed on React 18.
Root cause: React 18's
Children.toArray()strips BigInt values before ourflattenChildrenfunction sees them. The tests were going through JSX rendering, so BigInts were filtered out by React before we could test them.Fix: Call
flattenChildrendirectly with an array containing BigInts, bypassing React's JSX preprocessing. This tests the library's behavior in isolation.Test plan
🤖 Generated with Claude Code