Fixed dependencies and template issue#17
Open
alexqyle wants to merge 1 commit intogrundic:masterfrom
alexqyle:bug_dependencies_template
Open
Fixed dependencies and template issue#17alexqyle wants to merge 1 commit intogrundic:masterfrom alexqyle:bug_dependencies_template
alexqyle wants to merge 1 commit intogrundic:masterfrom
alexqyle:bug_dependencies_template
Conversation
|
I think, this should be merged. I can not access the travis logs to see, what problems were reported. @grundic Could you please look into this? |
dploeger
added a commit
to dodevops/puppet-teamcity
that referenced
this pull request
May 29, 2017
Owner
|
Hi @dploeger, |
|
@grundic Thanks. If you take a look at the CI logs, it complains about open dependencies in metadata.json and an incompatibility with ruby 1.9, because the gem public_suffix needs Ruby >=2.0.0. These were all changes, that were not introduced by this pull request. So we either need to fix the tests and leave out Ruby 1.9 or merge this pull request. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added anchor in class teamcity, so that it is possible to add dependencies for this module. (#16)
Fixed variable scope in build-agent-service.erb. Code was written by senax (#13).