Skip to content

Harden browser workbench control and guidance #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glittercowboy merged 5 commits into from
May 2, 2026
Merged

Harden browser workbench control and guidance #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84730d5
feat: harden browser control and approval policy
glittercowboy May 1, 2026
dbd19ef
feat: add safe browser runtime updater
glittercowboy May 1, 2026
2efa164
feat: refine browser tool guidance
glittercowboy May 1, 2026
2651ae2
chore: resolve protocol v0.35.0 checksum
glittercowboy May 1, 2026
c0655d7
fix: close browser approval and updater gaps
glittercowboy May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ go 1.26.2
require (
github.com/coder/websocket v1.8.14
github.com/creack/pty v1.1.24
github.com/gsd-build/protocol-go v0.34.0
github.com/gsd-build/protocol-go v0.35.0

@coderabbitai coderabbitai Bot May 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Verify tag existence on remote.
git ls-remote --tags https://github.com/gsd-build/protocol-go.git | rg 'refs/tags/v0\.35\.0$' || true

Repository: gsd-build/daemon

Length of output: 42

Tag v0.35.0 does not exist; unpublished revision blocks CI and reproducible builds.

Line 8 pins github.com/gsd-build/protocol-go v0.35.0, which cannot be resolved during builds. The tag must be created and pushed to the remote repository, or the dependency must be pinned to an existing commit or tag.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@go.mod` at line 8, The go.mod currently pins github.com/gsd-build/protocol-go
to a non-existent tag v0.35.0 which breaks CI; update go.mod to reference a
valid existing revision by either replacing the version string
"github.com/gsd-build/protocol-go v0.35.0" with an existing tag or
pseudo-version (or a specific commit hash) or create and push the v0.35.0 tag in
the remote repo; ensure you run `go get`/`go mod tidy` locally to verify the
chosen replacement resolves and commits the updated go.mod and go.sum.

github.com/spf13/cobra v1.10.2
gopkg.in/natefinch/lumberjack.v2 v2.2.1
)
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ github.com/coder/websocket v1.8.14/go.mod h1:NX3SzP+inril6yawo5CQXx8+fk145lPDC6p
github.com/cpuguy83/go-md2man/v2 v2.0.6/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
github.com/creack/pty v1.1.24 h1:bJrF4RRfyJnbTJqzRLHzcGaZK1NeM5kTC9jGgovnR1s=
github.com/creack/pty v1.1.24/go.mod h1:08sCNb52WyoAwi2QDyzUCTgcvVFhUzewun7wtTfvcwE=
github.com/gsd-build/protocol-go v0.34.0 h1:Au69NlKq4NULgmUvleNod+PUVa1AVy9HjGyO5o+7TMI=
github.com/gsd-build/protocol-go v0.34.0/go.mod h1:vECSwMFp59Ihu5ZH4aLF5fuW9zJ4a3ZXCYngmzfBn8s=
github.com/gsd-build/protocol-go v0.35.0 h1:Wg+QUFO0hXPc/EqQh93mOMV6hCJRBb4lyhODFKqrW6Q=
github.com/gsd-build/protocol-go v0.35.0/go.mod h1:vECSwMFp59Ihu5ZH4aLF5fuW9zJ4a3ZXCYngmzfBn8s=
github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2s0bqwp9tc8=
github.com/inconshreveable/mousetrap v1.1.0/go.mod h1:vpF70FUmC8bwa3OWnCshd2FqLfsEA9PFc4w1p2J65bw=
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
Expand Down
Loading