-
Notifications
You must be signed in to change notification settings - Fork 0
Add catalog-aware changeset gate #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gtbuchanan
wants to merge
5
commits into
main
Choose a base branch
from
catalog-changeset-gate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f37162d
Add catalog-aware changeset gate
gtbuchanan f195c41
Cover the catalog gate's filesystem and command layers
gtbuchanan 7b4733c
Scope the catalog gate's git commands to the workspace root
gtbuchanan 898ef8f
Tell a missing base file apart from a git failure
gtbuchanan 3d88276
Fold changeset status into gtb changeset check
gtbuchanan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| --- | ||
| '@gtbuchanan/cli': minor | ||
| --- | ||
|
|
||
| Add `gtb changeset check`, a catalog-aware changeset gate. | ||
|
|
||
| `changeset status` maps changed files to packages, but a pnpm catalog moves | ||
| every dependency range to `pnpm-workspace.yaml` at the workspace root, which | ||
| belongs to no package. A catalog bump therefore reads as "no package changed", | ||
| while pnpm rewrites `catalog:` to the concrete range at pack time — so every | ||
| consumer's published manifest moves with no version bump behind it, and the new | ||
| range sits unreleased until some unrelated PR happens to bump the package. | ||
|
|
||
| The gate diffs the `catalog:` / `catalogs:` blocks between a base ref and HEAD, | ||
| maps each changed entry to the published packages declaring it in a runtime | ||
| dependency field, and fails when no changeset covers them. `devDependencies`, | ||
| bundled dependencies, private packages, and anything in the changesets config's | ||
| `ignore` are excluded, and an empty changeset does not count as coverage. | ||
|
|
||
| The command runs `changeset status` first, so one invocation covers both the | ||
| stock "a changeset exists" requirement and the catalog gate against a single | ||
| base ref instead of specifying it twice. `changeset-check.yml` is now one step, | ||
| behind the same `gtb-from-source` input `cd.yml` uses. The | ||
| `pnpm-resolve-pinned` + `pnpm dlx` indirection is gone: it existed only to | ||
| avoid an install the gtb bin needs anyway, and it already required | ||
| `@changesets/cli` to be a root devDependency to resolve from the lockfile. | ||
|
|
||
| `PackageCapabilities` gains a `catalogDependencies` field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.