Repository navigation
Halo PR13 — invisible idle dock (alpha-order fix), ring-gradient icons, slimmer dock - #20
Merged
Merged
Conversation
…l + dock icons; slimmer dock - ROOT CAUSE (ghost capsule): .alpha() was declared AFTER .background()/.border() in the modifier chain — Compose alpha only wraps drawing after it, so the capsule stayed visible at alpha 0 while icons faded. Alpha now precedes background/border on the dock Row and wells. - New ringGradientFill modifier: offscreen layer + SrcIn mask fills any icon with the vertical ring gradient (top blue -> mid -> violet -> pink). Applied to +/-, Back, and Home (drawn opaque white then masked); Power keeps its semantic red. - Dock geometry: 76->64dp tall, wells 52->46dp. ./gradlew :app:assembleDebug :app:testDebugUnitTest — pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modifier.alphaonly wraps drawing that comes after it in the chain — the dock's background/border were declared before it, so they never faded. Alpha now precedes background/border (dock row + wells).ringGradientFillmodifier (offscreen compositing + SrcIn mask) fills the +/-, Back, and Home glyphs with the ring's own vertical gradient; Power keeps semantic red.Verification