Repository navigation
fix(wake): reliable WoL delivery, MAC backfill from probes, actionable failure hint - #24
Merged
Merged
Conversation
…hint Investigation found three silent failure modes in the wake path: 1. Manual-by-IP devices never had wifi/ethernet MACs stored (only SSDP discovery persisted them; the device-info probe wrote none back), so WoL was silently skipped. Every successful probe now backfills missing MACs (DeviceRegistry.backfillNetworkIdentity). 2. WoL sent one burst to 255.255.255.255 only — many routers/APs drop the global broadcast. Now sends 3 bursts to BOTH the global and the subnet-directed broadcast derived from the TV's own IP (wakeBroadcastAddresses, unit-tested), with a 500ms settle before the Home probe. 3. Wake failure feedback said nothing when no MAC existed; it now appends a 'rescan to capture a MAC' hint. Verification: ./gradlew :app:assembleDebug :app:testDebugUnitTest — pass (WakeBroadcastAddressesTest 4/4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigation findings (wake button "does not work")
DeviceRegistry.backfillNetworkIdentity, never overwriting known values).255.255.255.255— commonly dropped by routers/APs with client isolation. Wake now sends 3 bursts to both the global and the subnet-directed broadcast derived from the TV's IP (purewakeBroadcastAddresseshelper, 4 unit tests), with a 500ms settle before the Home keypress probe.Hardware caveat that no app change can lift: deep-off wake requires Fast TV Start (or equivalent) enabled on the TV; standby wake works over the network regardless.
Verification
./gradlew :app:assembleDebug :app:testDebugUnitTest — pass; WakeBroadcastAddressesTest 4/4.