Skip to content

fix(ui): scale swipe-up threshold with screen density and clean unused nav accent - #27

Open
gthgomez wants to merge 2 commits into
mainfrom
fix/gesture-threshold-density-and-cleanup
Open

gthgomez wants to merge 2 commits into
mainfrom
fix/gesture-threshold-density-and-cleanup

Conversation

@gthgomez

Copy link
Copy Markdown
Owner

Summary

Follow-up improvements to PR #26:

  1. Density-Aware Gesture Thresholding:
    • Replaced raw hardcoded pixel threshold (40f px) with density-scaled SwipeUpThresholdDp = 24.dp via LocalDensity.current.
    • Ensures consistent swipe sensitivity across low-density and high-density screens (e.g. xxxhdpi/QHD displays), preventing micro-drags from prematurely triggering the sheet.
  2. Bottom Navigation Cleanup:
    • Removed the obsolete and unused accent: Color parameter from NeoBottomNavigation and updated its call site in RGRemoteApp.kt to rely entirely on LocalHaloColors.

Verification

  • ./gradlew testDebugUnitTest: Passed (clean unit tests)
  • ./gradlew assembleDebug: Passed (successful build)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant