Cleanup: inline coursemodule_standard_elements, merge event_observer into observer#74
Draft
Copilot wants to merge 5 commits into
Draft
Cleanup: inline coursemodule_standard_elements, merge event_observer into observer#74Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
Co-authored-by: richardwolfmayr <24298463+richardwolfmayr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add dropdown field to assignment activity settings
Add Moodle 5 hook integration: assignment settings dropdown via hooks API
Mar 6, 2026
…of non-existent hook Co-authored-by: richardwolfmayr <24298463+richardwolfmayr@users.noreply.github.com>
Copilot
AI
changed the title
Add Moodle 5 hook integration: assignment settings dropdown via hooks API
Replace non-existent hook with real Moodle coursemodule_standard_elements callback
Mar 6, 2026
Copilot
AI
changed the title
Replace non-existent hook with real Moodle coursemodule_standard_elements callback
Replace non-existent Moodle hook with correct coursemodule_standard_elements callback
Mar 6, 2026
…into observer, remove hook/indirection files Co-authored-by: richardwolfmayr <24298463+richardwolfmayr@users.noreply.github.com>
Copilot
AI
changed the title
Replace non-existent Moodle hook with correct coursemodule_standard_elements callback
Cleanup: inline coursemodule_standard_elements, merge event_observer into observer
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation had unnecessary indirection through a
hook_listenerclass (no Moodle hook exists for module form injection) and split event handling across two observer classes with no meaningful distinction.Changes
lib.php— Form logic inlined directly intoblock_exaport_coursemodule_standard_elements(); no longer delegates to the removedhook_listenerclassclasses/observer.php—course_module_created()andcourse_module_updated()merged in from the now-deletedevent_observer.php; all event handling lives in one placedb/events.php— Course module event callbacks updated to reference\block_exaport\observerinstead of\block_exaport\event_observerDeleted
classes/hook_listener.phplib.phpclasses/event_observer.phpobserver.php; same namespace, same patterndb/hooks.php$callbacks = [])Original prompt
This pull request was created from Copilot chat.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.