Repository navigation
fix: keep a rejected HTTP start's failure through the status poll - #440
Merged
Merged
Conversation
The first-run HTTP card polls the proxy's status every 3 s and took each answer whole. A poll that found the proxy merely stopped knows nothing about why the start failed, so it replaced the failure with a plain start button: the operator saw the error for at most three seconds. On a slow runner the poll landed before the test's assertion, which is why 'a rejected start shows the failure' failed intermittently on Windows, on main and on PRs. A stopped reading no longer overwrites a failure with its error; any other state still replaces it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The guard exists to catch a rotation that waits for running commands, which here would mean waiting for sleep 99. One second failed on a Windows runner at 1205 ms while the rotation was correct; five seconds still tells a wait apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
Spec 062 的 PR #437 在 Windows unit 上連續失敗四次，每次落在不同檔案；
main最新一次 Windows CI 也失敗了。其中兩個可以從main修：first-run-record-terminal：這其實是產品缺陷。 首次設定的 HTTP 卡片每 3 秒輪詢一次 proxy 狀態，並直接用結果覆蓋卡片狀態。輪詢只知道 proxy「已停止」，不知道這次啟動為什麼失敗，所以啟動失敗的訊息最多 3 秒就被換成一般的啟動按鈕。runner 慢的時候，輪詢會搶在斷言之前發生，這就是測試時好時壞的原因。terminal-session-rotation：計時門檻太緊。 這個門檻是用來抓「轉換時等待正在執行的指令」，也就是等sleep 99；但 1000ms 在 Windows runner 上量到 1205ms，轉換本身並沒有錯。變更
HttpCaptureStep：如果目前狀態是帶錯誤訊息的failed，讀到stopped時不覆蓋它；其他狀態照常取代。3 秒輪詢和對焦重新驗證兩處都套用。不在這個 PR
bundle-export的 Python verifier 在 Windows 上卡超過 15 秒：這不像單純 runner 慢，可能是 Windows 上真的卡住。沒有 Windows 環境無法查，先不碰。export-attachment-list失敗的斷言：只存在於 Spec 062 分支，main上沒有。驗證
typecheck、verify:specs、verify:architecture、verify:i18n通過。🤖 Generated with Claude Code