typescript-node: Declare the typescript-node toolchain in .tool-versions - #161
Open
adamnfish-gu wants to merge 1 commit into
Open
typescript-node: Declare the typescript-node toolchain in .tool-versions#161adamnfish-gu wants to merge 1 commit into
adamnfish-gu wants to merge 1 commit into
Conversation
script/setup installs dependencies with yarn. .nvmrc goes, superseded by .tool-versions. script/start ran `yarn watch`, a tsc-watch loop that never exits. It now compiles and runs once, with the watch loop behind --watch, matching script/test. .yarn/install-state.gz was tracked despite the root .gitignore listing typescript-node/.yarn/*. It is a regenerated build artefact, so it is now untracked. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
script/setup installs dependencies with yarn. .nvmrc goes, superseded by .tool-versions.
script/start ran
yarn watch, a tsc-watch loop that never exits. It now compiles and runs once, with the watch loop behind --watch, matching script/test..yarn/install-state.gz was tracked despite the root .gitignore listing typescript-node/.yarn/*. It is a regenerated build artefact, so it is now untracked.
Base
fix/typescript-node(#160), so the diff shows only this branch's changes. Merge #160 first.Part of #143.