dot-net-core: Adopt .tool-versions and standardise scripts for dot-net-core - #167
Open
adamnfish-gu wants to merge 1 commit into
Open
dot-net-core: Adopt .tool-versions and standardise scripts for dot-net-core#167adamnfish-gu wants to merge 1 commit into
adamnfish-gu wants to merge 1 commit into
Conversation
No toolchain was pinned, script/setup used brew, which does not work on linux-arm64 CI, and script/test lacked set -euo pipefail. Pins dotnet 10 in .tool-versions and rewrites script/setup to check PATH. script/test and script/start follow the shared template and take a --watch flag, which runs dotnet watch test. Updates the README. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No toolchain was pinned, script/setup used brew, which does not work on linux-arm64 CI, and script/test lacked set -euo pipefail.
Pins dotnet 10 in .tool-versions and rewrites script/setup to check PATH. script/test and script/start follow the shared template and take a --watch flag, which runs dotnet watch test. Updates the README.
Base
fix/dot-net-core(#166), so the diff shows only this branch's changes. Merge #166 first.Part of #143.