Add Competition atom type - #220
Conversation
bcbddef to
a7540bf
Compare
a7540bf to
11ebe7f
Compare
…ublished by marjisound marjisound published release version 11.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0813.11ebe7fa using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 11.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0813.11ebe7fa Release-Initiated-By: https://github.com/marjisound Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/28358070847 Release-Notes: #220
|
@marjisound has published a preview version of this PR with release workflow run #62, based on commit 11ebe7f: 11.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0813.11ebe7fa Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the add-new-atom-for-match-day branch, or use the GitHub CLI command: gh workflow run release.yml --ref add-new-atom-for-match-day Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
11ebe7f to
762a656
Compare
…ublished by marjisound marjisound published release version 12.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0857.762a6566 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 12.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0857.762a6566 Release-Initiated-By: https://github.com/marjisound Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/28360413860 Release-Notes: #220
|
@marjisound has published a preview version of this PR with release workflow run #63, based on commit 762a656: 12.1.0-PREVIEW.add-new-atom-for-match-day.2026-06-29T0857.762a6566 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the add-new-atom-for-match-day branch, or use the GitHub CLI command: gh workflow run release.yml --ref add-new-atom-for-match-day Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
| 15: chart.ChartAtom chart | ||
| 16: audio.AudioAtom audio | ||
| 17: emailsignup.EmailSignUpAtom emailsignup | ||
| 18: footballcompetition.FootballCompetitionAtom footballCompetition |
There was a problem hiding this comment.
We need to decide if we want the model to have the field lowercase or camel case! For now I have left it camel case, but when porter stores it in s=elastic search it's encoded as lower case, and then concierge decodes it as camelcase.
…ublished by marjisound marjisound published release version 12.1.0-PREVIEW.add-new-atom-for-match-day.2026-07-15T1141.302c1611 using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 12.1.0-PREVIEW.add-new-atom-for-match-day.2026-07-15T1141.302c1611 Release-Initiated-By: https://github.com/marjisound Release-Workflow-Run: https://github.com/guardian/content-atom/actions/runs/29412531205 Release-Notes: #220
|
@marjisound has published a preview version of this PR with release workflow run #64, based on commit 302c161: 12.1.0-PREVIEW.add-new-atom-for-match-day.2026-07-15T1141.302c1611 Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the add-new-atom-for-match-day branch, or use the GitHub CLI command: gh workflow run release.yml --ref add-new-atom-for-match-day Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
1 participant
This PR introduces a new Competition atom type to convert the Match Day interactive atom into a structured atom, laying the groundwork for other competition-related interactive atoms (knockout, group tables, etc.) to be converted into atoms in the future.
We can categorise all of these components under a single atom type: Competition.
Rationale: Every component listed below relies on a single variable: the competitionId. Based on this ID, the component dynamically calls the right endpoint to get its relevant data. Because the underlying core dependency are identical, I think consolidating them into a single atom type simplifies our architecture.