Fix choice cards pill colour #15247
Open
Fix choice cards pill colour #15247
+187
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrf1
commented
Jan 29, 2026
| } | ||
|
|
||
| export interface ChoiceCardSettings { | ||
| export interface ChoiceCardDesignSettings { |
Member
Author
There was a problem hiding this comment.
renamed for clarity - this comes from the banner design tool
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in PROD the pill is red because that's what SDC sets in the choice cards settings if there's a discount:
The choice cards component "pill" colour can be configured in two ways:
Currently in the client the second overrides the first. But for banners we'd like to prioritise the banner design tool colours.
This PR changes the pill colours logic to do this.
For epics we'll still set the pill colour based on the choice card settings.
I've also added new storybook entries for the choice cards component which demonstrate this new logic