Strip commercial tag properties for DCR tag pages - #28964
Draft
jorgeazevedo wants to merge 1 commit into
Draft
Conversation
Contributor
This was referenced Jul 23, 2026
Contributor
Author
|
There are other properties from tags that are unused The largest ones are And the rest are I think it'd be worth exploring removing these ones as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Applies
withoutCommercialstripping to the tag pages DCR endpoint, mirroring what was done for fronts in #27894Taking the response from https://www.theguardian.com/tone/minutebyminute.json?dcr=true as an example. Every tag instance inside
contents[].properties.maybeContent.tags.tags[].propertiesis mapped to the DCR typeFETagType, which defines a number of tag properties(id,tagType,webTitle,sectionId,paidContentType,podcast) but does not includecommercial, even thoughtcommercialis part of the JSON.What this mean is that
commercialis sent by Frontend but silently discarded by DCR on deserialisation. Removing it drops the payload from ~800KB to ~457KB and the resulting HTML from DCR is byte-for-byte identical with and without the commercial data.How has this change been tested?
Have we considered potential risks?