Remove two-paragraph placement constraint for affiliate disclaimer - #29041
Open
ecguardian wants to merge 1 commit into
Open
Remove two-paragraph placement constraint for affiliate disclaimer#29041ecguardian wants to merge 1 commit into
ecguardian wants to merge 1 commit into
Conversation
…imer The affiliate disclaimer and links were previously gated on the article having at least two leading <p> elements with the second being 150+ chars. This was a layout constraint for older rendering that is no longer needed since DCR handles disclaimer placement independently. Now shouldAddAffiliateLinks delegates directly to the tag/switch/field check for all content types, matching the existing gallery behaviour.
ecguardian
added
the
maintenance
Contributor
andrewHEguardian
approved these changes
Aug 7, 2026
andrewHEguardian
left a comment
andrewHEguardian
left a comment
Contributor
There was a problem hiding this comment.
Lovely to remove that paragraph logic! ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The affiliate disclaimer and links were previously gated on the article having at least two leading
elements with the second being 150+ chars. This was a layout constraint for older rendering that is no longer needed since DCR handles disclaimer placement independently.
Now shouldAddAffiliateLinks delegates directly to the tag/switch/field check for all content types, matching the existing gallery behaviour.
What does this change?
what was changed:
Removed the two-paragraph constraint from
shouldAddAffiliateLinksinDotcomRenderingUtils.scala:294-301. The method now delegates directly toAffiliateLinksCleaner.shouldAddAffiliateLinksfor all content types (galleries and articles alike), without parsing HTML or checking paragraph structure.Removed the unused
org.jsoup.Jsoupimport since the HTML parsing logic was the only consumer.Screenshots
Checklist
data/databasefiles generated by tests are committed with this PR (the tests will fail in CI if you've forgotten to do this)