make cfnable domains clearer - #206
Merged
Merged
Conversation
johnduffell
commented
Jul 21, 2026
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| NS1 is our preferred supplier for DNS hosting. We pay for their dedicated DNS service, which is independent from their shared platform. This means that even if their shared platform experiences a DDOS attack, our DNS will still be available. | |||
Member
Author
There was a problem hiding this comment.
you can display the "rich diff" above,
or look at the preview here:
https://github.com/guardian/recommendations/blob/jd/clearer-docs/domain-names.md
johnduffell
enabled auto-merge (squash)
July 21, 2026 14:17
davidfurey
approved these changes
Jul 24, 2026
davidfurey
left a comment
davidfurey
left a comment
Member
There was a problem hiding this comment.
Thanks for the tip on rich diffs, looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs were not clear that theguardian.com isn't cfnable.
This PR makes it clear.