Close FileOutputStream in MonitorActivity.initMonitor() - #474
Open
munzzyy wants to merge 1 commit into
Open
Conversation
The .nomedia file is written with a raw FileOutputStream that's never closed, leaking a file descriptor every time monitoring is started or restarted. Switched to try-with-resources so the stream always closes, including when write() throws. Fixes guardianproject#469
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #469.
initMonitor()opens aFileOutputStreamto write the.nomediamarker file but never closes it:This runs every time monitoring starts (or restarts), so the descriptor leaks on every cycle. Swapped it for try-with-resources so the stream always gets closed, even if
write()throws.Small, single-purpose change, no behavior difference otherwise.