deploy: Fix system python handling - #506
Merged
Merged
Conversation
|
Successfully created backport PR for |
dvolodin7
added a commit
that referenced
this pull request
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the value assigned to
noc_init_python_pathin the "use system Python" branch of the NOC virtualenv bootstrap, so the correct system interpreter is used when the host provides one.Background
system_python3_path(init_venv_python3.yml:27) is the `register:` of a `stat` module call, not a path string. The original bare-scalar formnoc_init_python_path: system_python3_pathassigned the literal string `"system_python3_path"`; the first fix attempt{{ system_python3_path }}stringifies the entire register dict. Either way the interpreter string fed tovirtualenv_command(line 156) is invalid andvenvcreation fails on systems where the host has a matching system Python3.Change
ansible/noc_roles/noc/tasks/init_venv_python3.yml(+1/−1)noc_init_python_path: "{{ system_python3_path.stat.path }}"— extracts the resolved path from the `stat` register, consistent with.stat/.stdoutextraction already used elsewhere in this file.