Conversation
|
Successfully created backport PR for |
dvolodin7
added a commit
that referenced
this pull request
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused Facter fact-collection task from the
prepre-deployment Ansible role.What this does
Deletes the
Collect facts returned by factertask (setup: gather_subset: [facter]) fromansible/noc_roles/pre/tasks/facts.yml. The task ran FacterDetails
tower_ipset_facttasks in the same file are untouched.facterno longer appears anywhere in the repository after the change, and no role consumes Facter-produced facts.setup/gather_subsetare core Ansible modules not referenced elsewhere.